Add Asus ROG-GL552VW hardware #1508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianvazelle
force-pushed
the
asus-rog-gl552vw
branch
from
043bab7 to
5ef9708
Compare
Mic92
reviewed
Jul 1, 2025
asus/rog-gl552vw/default.nix
Outdated
|
|
||
| { | ||
| imports = [ | ||
| ../../common/cpu/intel |
There was a problem hiding this comment.
What Intel CPU generation is this? We got more specific modules for those.
There was a problem hiding this comment.
Thanks for your review, I switch to skylake
florianvazelle
force-pushed
the
asus-rog-gl552vw
branch
from
5ef9708 to
dc25b69
Compare
|
Hi @Mic92, it's OK for you ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add Asus ROG-GL552VW hardware
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input