-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.aiohttp: fix tests on Darwin #160959
Conversation
Result of |
@ofborg eval |
Result of 93 packages marked as broken and skipped:
1930 packages failed to build:
|
@ofborg eval |
Does |
Do you mean does the build fail only on Darwin? Yes I think so. I did it against staging because the rebuilds on Darwin was like 2,000 packages. |
No, I mean "Is the build on Darwin broken and not just flaky?"
That doesn't really matter if all of these builds were broken before. |
Ah, no not flaky. For a local build it's fully broken. However for whatever reason these |
Okay then let's go through staging. @ofborg eval |
Motivation for this change
Fixes failures during tests on Darwin. Similar to #126642, #145276, and #149128. Upstream does not seem interested in fixing this.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes