Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exa: remove as unmaintained upstream #253683

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Sep 6, 2023

Description of changes

ogham/exa#1243

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 6, 2023
@teto
Copy link
Member

teto commented Sep 6, 2023

Looks reasonable.

@wegank wegank merged commit 9699c06 into NixOS:master Sep 6, 2023
8 checks passed
@oxalica oxalica deleted the fix/drop-exa branch September 6, 2023 21:32
@rycee rycee mentioned this pull request Sep 7, 2023
6 tasks
@peterhoeg
Copy link
Member

Could we put in a compatibility symlink exa -> eza so that things don't break if people swap the packages?

@peterhoeg
Copy link
Member

I mean a symlink to the binary.

@teto
Copy link
Member

teto commented Sep 11, 2023

I find it more confusing than anything else, this should be up to users (else upstream would have relinquished the name)

@peterhoeg
Copy link
Member

peterhoeg commented Sep 11, 2023 via email

@cafkafk
Copy link
Member

cafkafk commented Sep 11, 2023

You could then argue that eza upstream should have a flag for putting in a compatibility symlink

Hi, I'm eza upstream. I'm not sure how such a flag would work, but feel free to create a feature request outlining this, or perhaps a PR.

@oxalica
Copy link
Contributor Author

oxalica commented Sep 11, 2023

I agree with @teto that it's confusing to alias one project to a fork maintained by a different group of people, even though the original author endorsed it. End-users should acknowledge this and then decide which one to use, or probably go back to coreutils.

@cafkafk
Copy link
Member

cafkafk commented Sep 11, 2023

maintained by a different group of people.

For the record, Mélanie Chauvel maintained exa for years and has been active in exa since 2018, and she is also a maintainer on eza.

I was made aware that Archlinux Extra does have symlink from exa to eza. There is also a noticeable amount of users that have asked for this.

That said, I personally prefer users making this a conscious choice.

But we might provide some feature flag that creates a symlink or something like it, and I'll make sure to add it to eza in nixpkgs on the following release as a lib.optional, in the same way we currently do gitSupport. That should make most people happy. (@peterhoeg)?

@oxalica
Copy link
Contributor Author

oxalica commented Sep 11, 2023

maintained by a different group of people.

For the record, Mélanie Chauvel maintained exa for years and has been active in exa since 2018, and she is also a maintainer on eza.

Okay, that's reasonable.

But we might provide some feature flag that creates a symlink or something like it, and I'll make sure to add it to eza in nixpkgs on the following release as a lib.optional

We can definitely do that, probably just in installPhase. An override-able parameter exaAlias could be fine, as we already have {vi,vim}Alias for neovim here. Since exa is already removed, having a true default seems fine to me.

@@ -496,6 +496,7 @@ mapAliases ({
euca2tools = throw "euca2ools has been removed because it is unmaintained upstream and still uses python2"; # Added 2022-01-01
evilvte = throw "evilvte has been removed from nixpkgs for being unmaintained with security issues and dependant on an old version of vte which was removed"; # Added 2022-01-14
evolution_data_server = throw "'evolution_data_server' has been renamed to/replaced by 'evolution-data-server'"; # Converted to throw 2022-02-22
exa = throw "'exa' has been removed because it is unmaintained upstream. Consider using 'eza', a maintained fork"; # Added 2023-09-07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

Suggested change
exa = throw "'exa' has been removed because it is unmaintained upstream. Consider using 'eza', a maintained fork"; # Added 2023-09-07
exa = eza; # Added 2023-09-07

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this was not acceptable before #254600. Now it is.

@dotlambda
Copy link
Member

else upstream would have relinquished the name

They didn't say they wouldn't because they didn't say anything.

eza is clearly a continuation of exa so the latter should be an alias.

@cafkafk
Copy link
Member

cafkafk commented Sep 13, 2023

I would like if you could at least keep a trace telling users that they're not installing exa

@teto
Copy link
Member

teto commented Sep 13, 2023

An override-able parameter exaAlias could be fine, as we already have {vi,vim}Alias for neovim here

and I find that weird too xD neovim is neither vim or vi so it's odd/confusing to create those aliases, especially as nix provides so many workarounds. Now that they are there I wont touch those but I feel we could have avoided that for eza/exa. Now I hope no one creates a new software called "exa" :s

Anyway I dont feel strongly about this but just to show creating the aliases is not obvious for everyone.

Fryuni added a commit to Fryuni/config-files that referenced this pull request Sep 13, 2023
viperML added a commit to viperML/dotfiles that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants