-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exa: remove as unmaintained upstream #253683
Conversation
Looks reasonable. |
Could we put in a compatibility symlink |
I mean a symlink to the binary. |
I find it more confusing than anything else, this should be up to users (else upstream would have relinquished the name) |
Exa upstream has allegedly gone AWOL. You could then argue that eza upstream should have a flag for putting in a compatibility symlink, but in order to follow the principle of least surprise, we could then handle it downstream.
|
Hi, I'm eza upstream. I'm not sure how such a flag would work, but feel free to create a feature request outlining this, or perhaps a PR. |
I agree with @teto that it's confusing to alias one project to a fork maintained by a different group of people, even though the original author endorsed it. End-users should acknowledge this and then decide which one to use, or probably go back to coreutils. |
For the record, Mélanie Chauvel maintained I was made aware that Archlinux Extra does have symlink from That said, I personally prefer users making this a conscious choice. But we might provide some feature flag that creates a symlink or something like it, and I'll make sure to add it to |
Okay, that's reasonable.
We can definitely do that, probably just in |
@@ -496,6 +496,7 @@ mapAliases ({ | |||
euca2tools = throw "euca2ools has been removed because it is unmaintained upstream and still uses python2"; # Added 2022-01-01 | |||
evilvte = throw "evilvte has been removed from nixpkgs for being unmaintained with security issues and dependant on an old version of vte which was removed"; # Added 2022-01-14 | |||
evolution_data_server = throw "'evolution_data_server' has been renamed to/replaced by 'evolution-data-server'"; # Converted to throw 2022-02-22 | |||
exa = throw "'exa' has been removed because it is unmaintained upstream. Consider using 'eza', a maintained fork"; # Added 2023-09-07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
exa = throw "'exa' has been removed because it is unmaintained upstream. Consider using 'eza', a maintained fork"; # Added 2023-09-07 | |
exa = eza; # Added 2023-09-07 |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, this was not acceptable before #254600. Now it is.
They didn't say they wouldn't because they didn't say anything.
|
I would like if you could at least keep a trace telling users that they're not installing exa |
and I find that weird too xD neovim is neither vim or vi so it's odd/confusing to create those aliases, especially as nix provides so many workarounds. Now that they are there I wont touch those but I feel we could have avoided that for eza/exa. Now I hope no one creates a new software called "exa" :s Anyway I dont feel strongly about this but just to show creating the aliases is not obvious for everyone. |
Description of changes
ogham/exa#1243
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)