[staging-next] perlPackages.XMLLibXML: 2.0209 -> 2.0210 and apply fix for tests #329641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrmaxmeier
requested review from
marcusramberg,
stigtsp and
zakame
as code owners
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
@ofborg build perlPackages.XMLLibXML |
stigtsp
reviewed
Jul 24, 2024
Member
stigtsp
left a comment
stigtsp
left a comment
There was a problem hiding this comment.
LGTM, but unable to test properly while on travels
Cc: @marcusramberg
Member
|
For reference, patch is from shlomif/perl-XML-LibXML#87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
perlPackages.XMLLibXMLis currently broken onstaging-next(#328673): https://hydra.nixos.org/build/267058672/nixlog/1/tailThe version bump allows dropping the patch that was previously applied (
XML-LibXML-clang16.patch) and the new patch fixes the tests when compiled against libxml2 2.13.0.The corresponding Arch package carries the same patch: https://gitlab.archlinux.org/archlinux/packaging/packages/perl-xml-libxml/-/commit/24281ef7636b2628af33e7e72b44b9533ef6cb24
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.