python312Packages.zarr: 2.18.7 -> 3.1.0 #373248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
3a338df to
88f4197
Compare
13 tasks
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
88f4197 to
e6e5922
Compare
ofborg
bot
added
the
2.status: merge conflict
dotlambda
reviewed
Feb 11, 2025
dotlambda
reviewed
Feb 11, 2025
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
e6e5922 to
6b93bb9
Compare
ofborg
bot
removed
the
2.status: merge conflict
bcdarwin
changed the title
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
6b93bb9 to
ffd6efa
Compare
Member
I can't find an upstream issue for that. Mind opening one? |
Contributor
Done, also for tifffile, and updated the top comment of the PR. Also, I pushed a few more commits related to the main topic of the PR. I also added there |
doronbehar
force-pushed
the
python3-zarr-v3
branch
from
ffd6efa to
6477f52
Compare
doronbehar
changed the title
Contributor
|
After working a bit with the patch here and with zarr v3 directly, I noticed that many features of it are missing in comparison to version 2.x. Even if the dependencies mentioned in the PR's top comment will adapt to v3, I think we should still have a |
doronbehar
force-pushed
the
python3-zarr-v3
branch
from
6477f52 to
0ba9f02
Compare
Contributor
|
Due to: And due to the fact non of the upstream issues in dependent projects have had any progress, I decided to decouple the I also rebased this PR to fix the natural merge conflict due to #396376 . |
doronbehar
force-pushed
the
python3-zarr-v3
branch
from
0ba9f02 to
d75eab0
Compare
doronbehar
changed the title
doronbehar
changed the title
doronbehar
force-pushed
the
python3-zarr-v3
branch
from
d75eab0 to
390e0bf
Compare
Contributor
|
A few updates:
|
Member
Author
|
It looks like these PRs are active and will likely be merged before the next NixOS release cycle, so I'd be fine with merging. If we do proceed, I'm not sure how much effort/mostly-duplicated code we should put into supporting Zarr 2 stuff in tree though. |
Contributor
OK, I see you are the maintainer also of |
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
7f3f825 to
2d6ead9
Compare
Member
Author
|
Multiscale-spatial-image stuff fully fixed (modulo potentially squashing). ome-zarr will also make a release soon. If not, patching may or may not be tedious but we could also temporarily bump to an unstable version, and then remove the pinned zarr/numcodecs stuff. |
bcdarwin
force-pushed
the
python3-zarr-v3
branch
2 times, most recently
from
fb73ee1 to
8c294eb
Compare
Contributor
|
I think we can wait to the weekend for ome/ome-zarr-py#463 too - it won't be a big deal a few more days after 7 months this PR was open :). |
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
8c294eb to
2e839e0
Compare
bcdarwin
force-pushed
the
python3-zarr-v3
branch
from
2e839e0 to
9fbc793
Compare
Member
Author
|
Updated to the ome-zarr release candidate and dropped the pinned versions of zarr and numcodecs. |
Contributor
|
Should be good to go after a Nixpkgs-review. I'm loaded at the moment. |
Member
Author
|
Member
Author
Looks like |
Contributor
|
I managed to build locally halide with this PR (rebased upon latest Hence, I'm merging 🎉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following packages need to be updated upstream to the Zarr 3.x. API:
python312Packages.tifffile: Zarr v3 compatibility? cgohlke/tifffile#282python312Packages.multiscale-spatial-image: zarr 3 spatial-image/multiscale-spatial-image#108python312Packages.ome-zarr: 0.12.0 release ome/ome-zarr-py#463python312Packages.reprojectThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.