toolong: 1.4.0 -> 1.5.0 #388011
Merged
toolong: 1.4.0 -> 1.5.0 #388011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polygon
reviewed
Mar 8, 2025
There was a problem hiding this comment.
The version update is fine. However, this fails to start for me (though that is also true for the version in nixpkgs already), likely due to #360671.
I've found this PR: Textualize/toolong#63 and condensed the relevant parts into a patch which I uploaded here: polygon@e438c8e
This should apply right on top of your PR and fix the package. Could you possibly verify this and apply it to this PR?
polygon
approved these changes
Mar 8, 2025
wegank
added
the
12.approvals: 1
Mindavi
approved these changes
Mar 9, 2025
|
Unfortunate that upstream did not tag properly. Maybe ask if they still want to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.