-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
nixos/zswap: init module #401335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/zswap: init module #401335
Conversation
55c9656 to
a8d7475
Compare
acid-bong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in the end: why making this a systemd script instead of kernel parameters (to start on boot) + activation scripts (to start and stop on rebuild)?
|
Also change |
a8d7475 to
b95f57c
Compare
|
Thank you for addressing #119244. Considering that we already have |
I took back what I said about |
What do you think the path forward is? I see a couple options:
|
I second this. Here's a draft PR that implements said module: #402455 |
|
Closing this PR in favor of a sysmodule config option. See any further discussion here #119244 |
Provides a NixOS module for enabling and configuring zswap, a compressed cache for swap pages within the kernel.
Closes #119244.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.