Skip to content

Conversation

@ryand56
Copy link
Member

@ryand56 ryand56 commented Aug 24, 2025

Introduced by #422496
Does not follow the current nixfmt style and CI lint check is failing

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@zowoq zowoq enabled auto-merge August 24, 2025 06:58
@zowoq zowoq merged commit 2ce0366 into NixOS:master Aug 24, 2025
23 of 27 checks passed
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 24, 2025
@ryand56 ryand56 deleted the kanri/nixfmt branch August 24, 2025 07:01
@Sigmanificient
Copy link
Member

This is my first time breaking nixpkgs master 🥲 How did this happen, i made quite curious, this CI was passing for the formatting 🤔

image

@zowoq
Copy link
Contributor

zowoq commented Aug 24, 2025

this CI was passing for the formatting

Yes, it passed last month with the old nixfmt but fails with the new nixfmt. Has happened a few times recently, see #431146. These issues shouldn't happen once the merge queue is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants