Skip to content

Conversation

@VuiMuich
Copy link
Contributor

@VuiMuich VuiMuich commented Sep 3, 2025

https://www.nushell.sh/blog/2025-09-02-nushell_0_107_0.html

Update plugins:

  • hcl
  • semver
  • skim

Mark plugin packages as broken:

  • highlight
  • units

closes #439911

Resolved #450157

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 3, 2025
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Sep 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: 06e88d7e805091d941c442f7ab37e5dd0d2836b8


x86_64-linux

✅ 6 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.polars
  • nushellPlugins.query
  • tests.writers.simple.nu

@timon-schelling
Copy link
Member

I’d prefer to wait a little while so the plugins have time to update, and we won’t need to mark them all as broken.

This PR could also include plugin updates.
See comment above nushell version.

@dtomvan
Copy link
Contributor

dtomvan commented Sep 3, 2025

I agree, but there are a bunch of plugins that don't update regularly, or look at PRs frequently enough.

For example:

@timon-schelling
Copy link
Member

We could decide to patch them. Trivial when only a version bump is needed and could be automated.

But for now, maybe wait a week or two.

@YPares
Copy link
Contributor

YPares commented Sep 6, 2025

@timon-schelling You mean plugins that are present in nixpkgs too? Because for other plugins it makes little sense to delay the merge, or even prevent breakage as users may just opt to stick to an older nixpkgs-unstable commit if they need compat with external tools. Also two weeks is basically half the development cycle of nushell.

@timon-schelling
Copy link
Member

@timon-schelling You mean plugins that are present in nixpkgs too? Because for other plugins it makes little sense to delay the merge, or even prevent breakage as users may just opt to stick to an older nixpkgs-unstable commit if they need compat with external tools. Also two weeks is basically half the development cycle of nushell.

Yes plugins in nixpkgs nushellPlugins.*.
I agree that we need a way to merge new nushell version relatively fast. Patching nu_plugin crate version should work for some plugins and some nushell updates.
I wanted to work on automating that but did not find time to do that last few days.

Anyways all plugins that break should be marked that way.
And plugins that have a compatible version should, in my opinion, be updated in this PR.

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Sep 7, 2025

I mean generally I can bump all the plugins to their respective latest version, but tbh it feels a bit out of scope for this PR imo, especially for plugins that need patching since the upstream repo is way behind.
Also I am not familar with using plugins in nushell at all, so I have no means to test.

If you strictly want to bump nushell and the plugins in one go, feel free to open a superseding PR that closes mine.
I just wanted 0.107.0 in asap to have the "immediate accept" feature.

@nix-owners nix-owners bot requested a review from koffydrop September 7, 2025 09:15
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Sep 7, 2025

Ok, of all the plugins that (potentially) requiriere an update, only semver and skim had a recent release that was not yet taken care of by other PRs so I'll include them here.

Those plugins should be fine as they already derive their version from the nushell package as far as my understanding goes:

  • formats
  • gstat
  • polars
  • query

These packages are updated here or in other PRs:

Already marked as broken are:

  • dbus
  • net

That leaves:

  • hcl
  • highlight
  • units
    I have no idea if they are actually incompatible to 0.107.0. If someone can report on this, I can mark those as broken as well, otherwise I would like to keep those three out of this PR.

@VuiMuich VuiMuich changed the title nushell: 0.106.1 -> 0.107.0 nushell: 0.106.1 -> 0.107.0, nushellPlugins.semver: 0.11.6 -> 0.11.7, nushellPlugins.skim: 0.17.0 -> 0.19.0 Sep 7, 2025
@nix-owners nix-owners bot requested a review from aftix September 7, 2025 09:37
@dtomvan
Copy link
Contributor

dtomvan commented Sep 7, 2025

Also I am not familar with using plugins in nushell at all, so I have no means to test.

I've included a test for each plugin, so you can build nushellPlugins.foo.passthru.tests.loadCheck to test if they work with the current nushell. Here's the command I use to get a nice overview of what does and doesn't work:

NIXPKGS_ALLOW_BROKEN=1 nom-build -E \
  'with import ./. { config.allowAliases = false; };
   lib.mapAttrs
   (_n: p: p.tests.loadCheck)
   (lib.filterAttrs (_n: lib.isDerivation) nushellPlugins)' \
   --keep-going
  • I have no idea if they are actually incompatible to 0.107.0. If someone can report on this, I can mark those as broken as well, otherwise I would like to keep those three out of this PR.

Generally, every nushell update the plugins become incompatible. They need to be compiled against the exact same version of the API. So you could mark hcl,highlight,units as broken for now so we can call it a day and merge this.

I might figure out a way to patch the plugin sources every update, but it would be better if plugin authors could test and release quickly after a new release of nushell... but from what I've seen nobody is really doing that proactively at all...

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Sep 7, 2025

I hope this desirable to have the "mark broken" as dedicated commit, or should I squash it into the nushell update commit?

Also should I update the PR title? I didn't do that yet, as it would become awkwardly long.

@nix-owners nix-owners bot requested review from Yethal and mgttlinger September 7, 2025 14:22
@Yethal
Copy link
Contributor

Yethal commented Sep 7, 2025

Give me a few hours, I'll release updated version of the hcl plugin and we'll add it to the pr

@YPares
Copy link
Contributor

YPares commented Sep 7, 2025

Generally, every nushell update the plugins become incompatible.

Yep, and for this reason I was surprised to see other plugins being added here, besides the main ones maintained by the nushell team and released in sync with nushell. I don't see the point of adding them to nixpkgs if they are likely to become broken one month later.

from what I've seen nobody is really doing that proactively at all

There are plans for improving plugins compat throughout several nushell version, but for now we have to live with that.

@koffydrop
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: 913f6e3f6709951d5ec4be050369c7d20fc1d834


x86_64-linux

✅ 8 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.semver
  • nushellPlugins.skim
  • tests.writers.simple.nu

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 10, 2025
@VuiMuich
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: fde9024da3bb53674ea77115b7575020cc990edc


x86_64-linux

✅ 9 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.hcl
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.semver
  • nushellPlugins.skim
  • tests.writers.simple.nu

@poliorcetics
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: fde9024da3bb53674ea77115b7575020cc990edc


aarch64-darwin

✅ 8 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.hcl
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.skim
  • tests.writers.simple.nu

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Sep 13, 2025
@jasonxue1
Copy link
Member

can you resolve #439911 here?

@VuiMuich
Copy link
Contributor Author

can you resolve #439911 here?

Yes, it already does.

@koffydrop
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: fde9024da3bb53674ea77115b7575020cc990edc


x86_64-linux

✅ 9 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.hcl
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.semver
  • nushellPlugins.skim
  • tests.writers.simple.nu

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2546

@FlameFlag
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 439871
Commit: fde9024da3bb53674ea77115b7575020cc990edc


x86_64-darwin

✅ 8 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.hcl
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.skim
  • tests.writers.simple.nu

aarch64-darwin

✅ 8 packages built:
  • nushell
  • nushellPlugins.formats
  • nushellPlugins.gstat
  • nushellPlugins.hcl
  • nushellPlugins.polars
  • nushellPlugins.query
  • nushellPlugins.skim
  • tests.writers.simple.nu

@VuiMuich
Copy link
Contributor Author

VuiMuich commented Oct 2, 2025

@Aleksanaa sorry to ping you explicitly, but you have been helpful getting dragging PRs over the finish line in the past.
Would you be so kind to give this a cursory look and if aok merge?

@jasonxue1
Copy link
Member

Could you add this:
Resolved #450157

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, and it seems this was extensively tested.

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 15, 2025
Merged via the queue into NixOS:master with commit c83d7a2 Oct 15, 2025
36 checks passed
@oscarvarto
Copy link
Contributor

Yay 🥳

@VuiMuich
Copy link
Contributor Author

Tanks for the merge @SigmaSquadron!

@VuiMuich VuiMuich deleted the nushell-0.107.0 branch October 15, 2025 05:56
@GustavoWidman
Copy link

merged just in time for 0.108 😭

@VuiMuich
Copy link
Contributor Author

I am glad it was merged just before the release and I didn't need to update the PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: nushell 0.106.1 → 0.107.0 Update Request: nu_plugin_skim 0.17.0 → 0.19.0