-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
nushell: 0.106.1 -> 0.107.0, nushellPlugins.*: update #439871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
I’d prefer to wait a little while so the plugins have time to update, and we won’t need to mark them all as broken. This PR could also include plugin updates. |
|
I agree, but there are a bunch of plugins that don't update regularly, or look at PRs frequently enough. For example: |
|
We could decide to patch them. Trivial when only a version bump is needed and could be automated. But for now, maybe wait a week or two. |
|
@timon-schelling You mean plugins that are present in nixpkgs too? Because for other plugins it makes little sense to delay the merge, or even prevent breakage as users may just opt to stick to an older nixpkgs-unstable commit if they need compat with external tools. Also two weeks is basically half the development cycle of nushell. |
Yes plugins in nixpkgs Anyways all plugins that break should be marked that way. |
|
I mean generally I can bump all the plugins to their respective latest version, but tbh it feels a bit out of scope for this PR imo, especially for plugins that need patching since the upstream repo is way behind. If you strictly want to bump nushell and the plugins in one go, feel free to open a superseding PR that closes mine. |
|
Ok, of all the plugins that (potentially) requiriere an update, only Those plugins should be fine as they already derive their version from the
These packages are updated here or in other PRs:
Already marked as broken are:
That leaves:
|
I've included a test for each plugin, so you can build NIXPKGS_ALLOW_BROKEN=1 nom-build -E \
'with import ./. { config.allowAliases = false; };
lib.mapAttrs
(_n: p: p.tests.loadCheck)
(lib.filterAttrs (_n: lib.isDerivation) nushellPlugins)' \
--keep-going
Generally, every nushell update the plugins become incompatible. They need to be compiled against the exact same version of the API. So you could mark hcl,highlight,units as broken for now so we can call it a day and merge this. I might figure out a way to patch the plugin sources every update, but it would be better if plugin authors could test and release quickly after a new release of nushell... but from what I've seen nobody is really doing that proactively at all... |
|
I hope this desirable to have the "mark broken" as dedicated commit, or should I squash it into the nushell update commit? Also should I update the PR title? I didn't do that yet, as it would become awkwardly long. |
|
Give me a few hours, I'll release updated version of the hcl plugin and we'll add it to the pr |
Yep, and for this reason I was surprised to see other plugins being added here, besides the main ones maintained by the nushell team and released in sync with nushell. I don't see the point of adding them to nixpkgs if they are likely to become broken one month later.
There are plans for improving plugins compat throughout several nushell version, but for now we have to live with that. |
|
|
|
|
can you resolve #439911 here? |
Yes, it already does. |
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2546 |
|
|
@Aleksanaa sorry to ping you explicitly, but you have been helpful getting dragging PRs over the finish line in the past. |
|
Could you add this: |
SigmaSquadron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good, and it seems this was extensively tested.
|
Yay 🥳 |
|
Tanks for the merge @SigmaSquadron! |
|
merged just in time for 0.108 😭 |
|
I am glad it was merged just before the release and I didn't need to update the PR 😅 |
https://www.nushell.sh/blog/2025-09-02-nushell_0_107_0.html
Update plugins:
Mark plugin packages as broken:
closes #439911
Resolved #450157
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.