Skip to content

Conversation

@widlarizer
Copy link
Contributor

Bump version to 0.57 and undo no longer needed patch from #428579 since YosysHQ/yosys#5182 is included in 0.57. Also add a comment for when another patch could be removed

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

cc @tsandrini

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Sep 11, 2025
@tsandrini
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442072
Commit: 119dd019ee7de47e5f9130e3fcd5d328c4dcddb1


x86_64-linux

❌ 29 packages failed to build:
  • cynthion (python313Packages.cynthion)
  • cynthion.dist (python313Packages.cynthion.dist)
  • glasgow
  • glasgow.dist
  • python312Packages.amaranth
  • python312Packages.amaranth-boards
  • python312Packages.amaranth-boards.dist
  • python312Packages.amaranth-soc
  • python312Packages.amaranth-soc.dist
  • python312Packages.amaranth.dist
  • python312Packages.cynthion
  • python312Packages.cynthion.dist
  • python312Packages.luna-soc
  • python312Packages.luna-soc.dist
  • python312Packages.luna-usb
  • python312Packages.luna-usb.dist
  • python313Packages.amaranth
  • python313Packages.amaranth-boards
  • python313Packages.amaranth-boards.dist
  • python313Packages.amaranth-soc
  • python313Packages.amaranth-soc.dist
  • python313Packages.amaranth.dist
  • python313Packages.luna-soc
  • python313Packages.luna-soc.dist
  • python313Packages.luna-usb
  • python313Packages.luna-usb.dist
  • sby
  • silice
  • yosys-synlig
✅ 12 packages built:
  • fusesoc
  • fusesoc.dist
  • mcy
  • openroad
  • python312Packages.edalize
  • python312Packages.edalize.dist
  • python312Packages.yosys
  • python313Packages.edalize
  • python313Packages.edalize.dist
  • yosys (python313Packages.yosys)
  • yosys-bluespec
  • yosys-ghdl

Error logs: `x86_64-linux`
silice
CMake Deprecation Warning at src/libs/lua/CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.

CMake Deprecation Warning at src/libs/luabind-deboostified/CMakeLists.txt:6 (cmake_minimum_required):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.

Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.

-- Linking with: stdc++fs
-- Configuring incomplete, errors occurred!

yosys-synlig
/build/source/src/mods/yosys_ast/synlig_ilang.cc: In member function 'virtual void Synlig::WriteIlangAlias::execute(std::vector >, Yosys::RTLIL::Design*)':
/build/source/src/mods/yosys_ast/synlig_ilang.cc:18:27: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector >::size_type' {aka 'long unsigned int'} [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
   18 |         for (int i = 1; i < args.size(); i++)
      |                         ~~^~~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc: In lambda function:
/build/source/src/mods/yosys_ast/synlig_edif.cc:328:38: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
  328 |                 for (size_t i = 0; i < val.size(); i += 4) {
      |                                    ~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:330:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
  330 |                     if (i + 0 < val.size() && val.at(i + 0) == RTLIL::State::S1)
      |                         ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:332:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
  332 |                     if (i + 1 < val.size() && val.at(i + 1) == RTLIL::State::S1)
      |                         ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:334:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
  334 |                     if (i + 2 < val.size() && val.at(i + 2) == RTLIL::State::S1)
      |                         ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:336:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
  336 |                     if (i + 3 < val.size() && val.at(i + 3) == RTLIL::State::S1)
      |                         ~~~~~~^~~~~~~~~~~~

@tsandrini
Copy link
Contributor

I can confirm that the package builds and works on x86_64-linux as expected, but it seems like this bump generates a bunch of regressions in packages dependent on yosys :/

@tsandrini tsandrini added the 8.has: package (update) This PR updates a package to a newer version label Oct 6, 2025
@eljamm eljamm mentioned this pull request Dec 16, 2025
@gonsolo
Copy link
Contributor

gonsolo commented Jan 10, 2026

Superseded by #471062.

@gonsolo gonsolo closed this Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants