Revert "stdenv: pURL implementation (#421125)"

[h0nIg]

#421125 introduced a problem with checkMeta=true for nixpkgs-review. checkMeta defaults to false in general.

The scenario happened for thunderbird-bin in combination with an unsupported platform.
This PR prevents any evaluation which might be problematic

There were concerns, that a revert may be a better option. I keep this PR open and let the community decide: #453291

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

I'm confused by the commit message:

This reverts commit h0nIg@5427115, reversing
changes made to h0nIg@88ee2ac.

The second commit seems very much unrelated. What am I missing?

Please clarify the reason for the revert in the commit message, aka refer to the cases that were broken for Eval.

[h0nIg]

I'm confused by the commit message:

This reverts commit h0nIg@5427115, reversing
changes made to h0nIg@88ee2ac.

The second commit seems very much unrelated. What am I missing?

Please clarify the reason for the revert in the commit message, aka refer to the cases that were broken for Eval.

it is the revert based on the latest master which i had locally (88ee2ac). This was the result of a standard git revert SHA -m 1

[wolfgangwalther]

This was the result of a standard git revert SHA -m 1

Thanks, never seen that!

[wolfgangwalther]

Merging this to unbreak the various issues we have with meta depending on src. To clarify my comment on the other PR: I understand this will be necessary, but we will need better tooling to make such a change with confidence.

For me that means:

• We need to eval more packages than just those build on hydra.
• We need to eval and diff meta.

Once we do this, we can much better judge the impact of such a change. We can then tell whether it was just these 1-2 broken packages - or whether there were a lot more elsewhere.

I don't have an immediate solution for you, but the above two things have been on my list for a while and I have been thinking about them.

[raboof]

We can then tell whether it was just these 1-2 broken packages - or whether there were a lot more elsewhere.

I agree that would be helpful. The cplex thing was a huge hack anyway, tbh for that case I would be fine with some bespoke change (like explicitly setting a purl).

[jopejoe1]

Note that there are quite a few of those hacks in nixpkgs.

[raboof]

sure, just saying it'd be helpful to get a feel for how many - I'd be fine with 5 or even 50, but perhaps not 500 :)

[jopejoe1]

My guess would be somewhere in the 10s but never really did a full scan will hack something together to get you a list (should not take that long to write)

[jopejoe1]

With a simple script, it got the following, which have non-evaluating src:

List of non-evaluating src

trace: ** cplex
trace: ** dyalog
trace: ** elasticsearchPlugins.analysis-lemmagen
trace: ** input-fonts
trace: ** joypixels
trace: ** libreoffice-bin
trace: ** linuxKernel.packages.linux_5_10.nvidia_dc
trace: ** linuxKernel.packages.linux_5_10.nvidia_dc_535
trace: ** linuxKernel.packages.linux_5_10.nvidia_dc_565
trace: ** linuxKernel.packages.linux_5_10.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_5_10.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_5_10.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_5_15.nvidia_dc
trace: ** linuxKernel.packages.linux_5_15.nvidia_dc_535
trace: ** linuxKernel.packages.linux_5_15.nvidia_dc_565
trace: ** linuxKernel.packages.linux_5_15.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_5_15.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_5_15.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_5_4.nvidia_dc
trace: ** linuxKernel.packages.linux_5_4.nvidia_dc_535
trace: ** linuxKernel.packages.linux_5_4.nvidia_dc_565
trace: ** linuxKernel.packages.linux_5_4.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_5_4.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_5_4.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_1.nvidia_dc
trace: ** linuxKernel.packages.linux_6_1.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_1.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_1.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_1.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_1.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_12.nvidia_dc
trace: ** linuxKernel.packages.linux_6_12.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_12.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_12.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_12.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_12.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_dc
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_12_hardened.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_16.nvidia_dc
trace: ** linuxKernel.packages.linux_6_16.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_16.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_16.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_16.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_16.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_17.nvidia_dc
trace: ** linuxKernel.packages.linux_6_17.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_17.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_17.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_17.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_17.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_6_6.nvidia_dc
trace: ** linuxKernel.packages.linux_6_6.nvidia_dc_535
trace: ** linuxKernel.packages.linux_6_6.nvidia_dc_565
trace: ** linuxKernel.packages.linux_6_6.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_6_6.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_6_6.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_hardened.nvidia_dc
trace: ** linuxKernel.packages.linux_hardened.nvidia_dc_535
trace: ** linuxKernel.packages.linux_hardened.nvidia_dc_565
trace: ** linuxKernel.packages.linux_hardened.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_hardened.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_hardened.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_lqx.nvidia_dc
trace: ** linuxKernel.packages.linux_lqx.nvidia_dc_535
trace: ** linuxKernel.packages.linux_lqx.nvidia_dc_565
trace: ** linuxKernel.packages.linux_lqx.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_lqx.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_lqx.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_xanmod.nvidia_dc
trace: ** linuxKernel.packages.linux_xanmod.nvidia_dc_535
trace: ** linuxKernel.packages.linux_xanmod.nvidia_dc_565
trace: ** linuxKernel.packages.linux_xanmod.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_xanmod.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_xanmod.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_dc
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_dc_535
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_dc_565
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_xanmod_latest.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_dc
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_dc_535
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_dc_565
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_xanmod_stable.nvidia_x11_legacy470
trace: ** linuxKernel.packages.linux_zen.nvidia_dc
trace: ** linuxKernel.packages.linux_zen.nvidia_dc_535
trace: ** linuxKernel.packages.linux_zen.nvidia_dc_565
trace: ** linuxKernel.packages.linux_zen.nvidia_x11_legacy340
trace: ** linuxKernel.packages.linux_zen.nvidia_x11_legacy390
trace: ** linuxKernel.packages.linux_zen.nvidia_x11_legacy470
trace: ** linuxPackages.nvidia_dc
trace: ** linuxPackages.nvidia_dc_535
trace: ** linuxPackages.nvidia_dc_565
trace: ** linuxPackages.nvidia_x11_legacy340
trace: ** linuxPackages.nvidia_x11_legacy390
trace: ** linuxPackages.nvidia_x11_legacy470
trace: ** linuxPackages_latest.nvidia_dc
trace: ** linuxPackages_latest.nvidia_dc_535
trace: ** linuxPackages_latest.nvidia_dc_565
trace: ** linuxPackages_latest.nvidia_x11_legacy340
trace: ** linuxPackages_latest.nvidia_x11_legacy390
trace: ** linuxPackages_latest.nvidia_x11_legacy470
trace: ** linuxPackages_lqx.nvidia_dc
trace: ** linuxPackages_lqx.nvidia_dc_535
trace: ** linuxPackages_lqx.nvidia_dc_565
trace: ** linuxPackages_lqx.nvidia_x11_legacy340
trace: ** linuxPackages_lqx.nvidia_x11_legacy390
trace: ** linuxPackages_lqx.nvidia_x11_legacy470
trace: ** linuxPackages_xanmod.nvidia_dc
trace: ** linuxPackages_xanmod.nvidia_dc_535
trace: ** linuxPackages_xanmod.nvidia_dc_565
trace: ** linuxPackages_xanmod.nvidia_x11_legacy340
trace: ** linuxPackages_xanmod.nvidia_x11_legacy390
trace: ** linuxPackages_xanmod.nvidia_x11_legacy470
trace: ** linuxPackages_xanmod_latest.nvidia_dc
trace: ** linuxPackages_xanmod_latest.nvidia_dc_535
trace: ** linuxPackages_xanmod_latest.nvidia_dc_565
trace: ** linuxPackages_xanmod_latest.nvidia_x11_legacy340
trace: ** linuxPackages_xanmod_latest.nvidia_x11_legacy390
trace: ** linuxPackages_xanmod_latest.nvidia_x11_legacy470
trace: ** linuxPackages_xanmod_stable.nvidia_dc
trace: ** linuxPackages_xanmod_stable.nvidia_dc_535
trace: ** linuxPackages_xanmod_stable.nvidia_dc_565
trace: ** linuxPackages_xanmod_stable.nvidia_x11_legacy340
trace: ** linuxPackages_xanmod_stable.nvidia_x11_legacy390
trace: ** linuxPackages_xanmod_stable.nvidia_x11_legacy470
trace: ** linuxPackages_zen.nvidia_dc
trace: ** linuxPackages_zen.nvidia_dc_535
trace: ** linuxPackages_zen.nvidia_dc_565
trace: ** linuxPackages_zen.nvidia_x11_legacy340
trace: ** linuxPackages_zen.nvidia_x11_legacy390
trace: ** linuxPackages_zen.nvidia_x11_legacy470
trace: ** oilrush
trace: ** orbstack
trace: ** ovftool
trace: ** postgresql18Packages.age
trace: ** postgresql18Packages.pgaudit
trace: ** raycast
trace: ** segger-jlink
trace: ** segger-jlink-headless
trace: ** tidgi
trace: ** xxe-pe
trace: ** yabai