Skip to content

Conversation

@hsjobeki
Copy link
Contributor

Improve the docs for recursiveUpdateUntil

  • Inconsistent grammar usage merge vs update
  • Inconsistent use of left attribute set vs first attribute set.
  • Break up the long single sentence into individual more clear focused sentences.
  • fix variable namings

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki force-pushed the lib-recursiveupdate-docs branch from d28f6be to 4e9043e Compare October 21, 2025 08:52
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: lib The Nixpkgs function library labels Oct 21, 2025
@nix-owners nix-owners bot requested a review from infinisil October 21, 2025 08:58
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@hsjobeki hsjobeki requested a review from roberth October 21, 2025 11:52
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can be more explicit, and there's more to say :)

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 5, 2025
@hsjobeki hsjobeki force-pushed the lib-recursiveupdate-docs branch from 4e9043e to aee088b Compare January 8, 2026 15:18
@hsjobeki
Copy link
Contributor Author

hsjobeki commented Jan 8, 2026

@roberth i've applied most of your changes. But i have omitted some of the formal definitions. I don't think they are really necessary. This should be a nice improvement now. If we notice that we need more formal definitions we can add them later if that sounds good to you.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 8, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 8, 2026
@hsjobeki hsjobeki force-pushed the lib-recursiveupdate-docs branch from aee088b to 5c83206 Compare January 9, 2026 08:40
@hsjobeki hsjobeki enabled auto-merge January 9, 2026 08:41
@mdaniels5757 mdaniels5757 force-pushed the lib-recursiveupdate-docs branch from 5c83206 to eda04ce Compare January 15, 2026 01:39
@mdaniels5757
Copy link
Member

Rebased and ran treefmt.

@hsjobeki hsjobeki added this pull request to the merge queue Jan 15, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jan 15, 2026
Merged via the queue into NixOS:master with commit df70bd5 Jan 15, 2026
25 checks passed
@hsjobeki hsjobeki deleted the lib-recursiveupdate-docs branch January 15, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants