Skip to content

python3.pkgs.paddle{ocr,x}: various improvements #475820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
doronbehar wants to merge 10 commits into
base: master
Choose a base branch
from
Open

python3.pkgs.paddle{ocr,x}: various improvements #475820

doronbehar wants to merge 10 commits into from

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jan 1, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from fb3b788 to 19eb5a4 Compare January 1, 2026 08:09
@nixpkgs-ci nixpkgs-ci bot requested review from kyehn, natsukium and osbm January 1, 2026 08:14
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 1, 2026
@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from 19eb5a4 to 1b64e8a Compare January 1, 2026 08:18
@qzylinra
Copy link
Contributor

qzylinra commented Jan 1, 2026

Is the large amount of rebuilding due to datasets? Is it necessary?

@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from 1b64e8a to e641977 Compare January 1, 2026 15:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 1, 2026
@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 1, 2026

Is the large amount of rebuilding due to datasets? Is it necessary?

Indeed it seems so, and it is not even necessary for this PR :) (I had a messy rebase after staging-next got merged). Here's the update of it anyway:

qzylinra
qzylinra reviewed Jan 1, 2026
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 1, 2026
qzylinra
qzylinra reviewed Jan 3, 2026
View reviewed changes
@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from e641977 to d32c1a5 Compare January 4, 2026 14:05
@doronbehar doronbehar requested a review from qzylinra January 4, 2026 15:02
@qzylinra
Copy link
Contributor

qzylinra commented Jan 4, 2026

What is the purpose of adding premailer here?

@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 4, 2026

What is the purpose of adding premailer here?

Good question! It is needed in order to use paddleocr. In an imperative setup, if paddlex[ocr] is installed, it installs premailer too:

https://github.com/PaddlePaddle/PaddleX/blob/37f1ffdc1daae40bbc5e17141d064951be9796ed/setup.py#L169-L177

@qzylinra
Copy link
Contributor

qzylinra commented Jan 4, 2026

In fact, only the document_to_workbook function needs it. https://github.com/PaddlePaddle/PaddleX/blob/37f1ffdc1daae40bbc5e17141d064951be9796ed/paddlex/inference/utils/io/tablepyxl.py#L111

Will it work correctly? #348580

@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 4, 2026

Well surprisingly you are right - although the premailer dependency appears in that upstream OCR list, in my development environment it wasn't needed. So I removed it. Thanks for the link.

@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from d32c1a5 to 9a8c01e Compare January 4, 2026 18:01
SuperSandro2000
SuperSandro2000 reviewed Jan 4, 2026
View reviewed changes
@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from 9a8c01e to 0d58c5d Compare January 5, 2026 09:50
@doronbehar doronbehar force-pushed the pkg/python-paddleocr branch from 0d58c5d to 1a67e1d Compare January 5, 2026 09:51
@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 5, 2026

Thank you very much for your reviews and the approval. I'd like to merge this tomorrow if there are no further objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kyehn kyehn Awaiting requested review from kyehn

@natsukium natsukium Awaiting requested review from natsukium

@osbm osbm Awaiting requested review from osbm

+1 more reviewer

@qzylinra qzylinra qzylinra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @qzylinra @SuperSandro2000