Skip to content

Conversation

@ddogfoodd
Copy link
Contributor

Changelog: https://github.com/fish-shell/fish-shell/releases/tag/4.3.3
Diff: fish-shell/fish-shell@4.3.2...4.3.3

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 7, 2026
@adamcstephens adamcstephens added the backport release-25.11 Backport PR automatically label Jan 7, 2026
@adamcstephens
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477720 --additional-package fish.tests --skip-package mise
Commit: f3910d1ac9cbc72fab194a22fd2a774c9e0f872f


x86_64-linux

✅ 31 packages built:
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batpipe
  • bat-extras.batwatch
  • bat-extras.core
  • bat-extras.prettybat
  • direnv
  • fish
  • fish-lsp
  • fish.doc
  • fish.tests.fishConfig
  • fish.tests.nixos
  • fishMinimal
  • fishMinimal.doc
  • fishPlugins.bass
  • fishPlugins.done
  • fishPlugins.fishtape
  • fishPlugins.fishtape_3
  • fishPlugins.fzf-fish
  • fishPlugins.humantime-fish
  • fishPlugins.pure
  • fzf-git-sh
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo
  • oh-my-fish
  • swaynotificationcenter
  • tests.writers.bin.fish
  • tests.writers.simple.fish

aarch64-linux

✅ 31 packages built:
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batpipe
  • bat-extras.batwatch
  • bat-extras.core
  • bat-extras.prettybat
  • direnv
  • fish
  • fish-lsp
  • fish.doc
  • fish.tests.fishConfig
  • fish.tests.nixos
  • fishMinimal
  • fishMinimal.doc
  • fishPlugins.bass
  • fishPlugins.done
  • fishPlugins.fishtape
  • fishPlugins.fishtape_3
  • fishPlugins.fzf-fish
  • fishPlugins.humantime-fish
  • fishPlugins.pure
  • fzf-git-sh
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo
  • oh-my-fish
  • swaynotificationcenter
  • tests.writers.bin.fish
  • tests.writers.simple.fish

I skipped mise after two hours of it trying to build on my rpi4.

@adamcstephens adamcstephens added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:master with commit 71b973c Jan 7, 2026
31 of 33 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 7, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-477720-to-release-25.11 origin/release-25.11
cd .worktree/backport-477720-to-release-25.11
git switch --create backport-477720-to-release-25.11
git cherry-pick -x f3910d1ac9cbc72fab194a22fd2a774c9e0f872f

@ddogfoodd ddogfoodd deleted the update-fish branch January 7, 2026 19:23
@adamcstephens
Copy link
Contributor

Ahh we never backported 4.3. Guess we’ll diverge from stable then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants