Skip to content

Conversation

@Aleksanaa
Copy link
Member

This restricts github automatically merging master with commit message "Merge branch 'NixOS:master' into ...". Although we don't explicitly prohibit not space after colons, we don't use it in any of the examples. It's also enforced in https://www.conventionalcommits.org/en/v1.0.0/

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

This restricts github automatically merging master with commit message
"Merge branch 'NixOS:master' into ...". Although we don't explicitly
prohibit not space after colons, we don't use it in any of the examples.
It's also enforced in https://www.conventionalcommits.org/en/v1.0.0/
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions backport release-25.11 Backport PR automatically labels Jan 9, 2026
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restricts github automatically merging master with commit message "Merge branch 'NixOS:master' into ...".

Out of curiosity, what are our commit conventions for merging branches into each other (e.g. merging master into staging)?

@Aleksanaa
Copy link
Member Author

There is no such standard. Writing it that way is fine, for example, when maintaining staging-next. This script doesn't check for this situation. However, merge commits shouldn't appear in regular pull requests.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 9, 2026
@MattSturgeon MattSturgeon added this pull request to the merge queue Jan 9, 2026
Merged via the queue into NixOS:master with commit 513e3a2 Jan 9, 2026
32 of 36 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 9, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 9, 2026
@MattSturgeon
Copy link
Contributor

This script doesn't check for this situation. However, merge commits shouldn't appear in regular pull requests.

Makes sense. I think I had in the back of my mind that there was some discussion on using PRs to do the staging -> master merge.1

Footnotes

  1. https://github.com/NixOS/org/issues/130#issuecomment-3004390494

@Aleksanaa
Copy link
Member Author

There's a rabbit hole though: github revert commit doesn't follow the convention, but as long as the original commit follows the convention, it still passes the check 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants