-
Notifications
You must be signed in to change notification settings - Fork 27
rulesets/nixpkgs: allow dependabot branch creation #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rulesets/nixpkgs: allow dependabot branch creation #144
Conversation
Dependabot can't create branches anymore to update github-actions.
b228fbe to
df53f27
Compare
infinisil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, applied!
|
Hm, that didn't seem to work, yet: https://github.com/NixOS/nixpkgs/network/updates/14302654/jobs Tried twice, both still failed with that "can't create branch" error. |
|
Older dependabot PRs are here: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr%20author%3Aapp%2Fdependabot%20is%3Aclosed The branch pattern is certainly (that's good) That's bad. |
| "refs/heads/revert-*", | ||
| "refs/heads/revert-*/**" | ||
| "refs/heads/revert-*/**", | ||
| "refs/heads/dependabot/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, maybe I misread the docs, they say:
You can include any number of slashes after qa with
qa/**/*
So maybe:
refs/heads/dependabot/**/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we need the same for the revert branch, so:
refs/heads/revert-*/**/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infinisil should I create a new PR about this or did you keep track of this?
Dependabot can't create branches anymore to update github-actions: https://github.com/NixOS/nixpkgs/network/updates
Broke in #132.
I hope this fixes it, but the double star glob was confusing the last time, so let's see...