Skip to content

Svelte rdi 3 - #4

Open
nosovk wants to merge 13 commits into
masterfrom
svelte-rdi-3
Open

nosovk wants to merge 13 commits into
masterfrom
svelte-rdi-3

Conversation

@nosovk

@nosovk nosovk commented Oct 8, 2022

Copy link
Copy Markdown
Member

No description provided.

Comment thread .eslintrc.cjs Outdated
Comment thread package.json Outdated
Comment thread postcss.config.cjs Outdated
@@ -0,0 +1,7 @@
const autoprefixer = require('autoprefixer');

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check is MJS option available for now, looks like yes
svelte-add/svelte-add#209
we are not going to use Tailwind, and it seems that Vite can load ESM config directly

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот тут не получилось, не совсем понял. Переделал, импортнул в sveltekit, вроде работает

Comment thread src/hooks.server.ts Outdated
Comment thread src/lib/Counter.svelte Outdated
Comment thread svelte.config.js Outdated

@nosovk nosovk left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct adapter is blocker

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 10, 2022

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2fac544
Status: ✅  Deploy successful!
Preview URL: https://3e43c6ae.redirectinspector-com.pages.dev
Branch Preview URL: https://svelte-rdi-3.redirectinspector-com.pages.dev

View logs

Comment thread package.json Outdated
@@ -12,6 +12,7 @@
},
"devDependencies": {
"@sveltejs/adapter-auto": "next",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

этот тогда нужно удалить

Comment thread package.json Outdated
},
"devDependencies": {
"@sveltejs/adapter-auto": "next",
"@sveltejs/adapter-cloudflare": "^1.0.0-next.38",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут должно быть next

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Версию тут можно руками ставить? Даже когда запускаю npm install @sveltejs/adapter-cloudflare@next оно вот так ставит по умолчанию

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да, просто руками "next" и сделать npm i после этого

@nosovk

nosovk commented Oct 11, 2022

Copy link
Copy Markdown
Member Author

https://svelte-rdi-3.redirectinspector-com.pages.dev/
превью лежит тут, я предлагаю:

  1. доочищать проект от стилей и ассетов демки
  2. favicon etc взять из https://git.nodeart.app/projects/RDI/repos/redirectinspector.com/browse/src
  3. оставить два роута - основной с обработкой get params, и /about с информацией что это такое.
  4. сделать стор для обработки get params (как в RLS)
  5. ознакомится со старым интерфейсом и redirectdetective.com чтобы понимать что оно такое

Comment thread svelte.config.js Outdated
@@ -1,4 +1,5 @@
import adapter from '@sveltejs/adapter-cloudflare';
// import adapter from '@sveltejs/adapter-cloudflare';
import adapter from '@sveltejs/adapter-static';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут был правильный, так не ок. Так билд не сработает сейчас.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

а до этого работало

@nosovk

nosovk commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

билд снова работает https://svelte-rdi-3.redirectinspector-com.pages.dev/
добавь теперь парсинг get параметров в store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants