build: bump revm to commit aceb093 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c112f1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Wodann
commented
May 1, 2024
| @@ -14,7 +14,7 @@ fn bomb_delay(spec_id: SpecId) -> u64 { | |||
| // SpecId::LONDON => 9500000, // EIP-3554 | |||
| SpecId::ARROW_GLACIER => 10700000, | |||
| SpecId::GRAY_GLACIER => 11400000, | |||
| SpecId::MERGE | SpecId::SHANGHAI | SpecId::CANCUN | SpecId::LATEST => { | |||
There was a problem hiding this comment.
Prague was added to the SpecId. Given that rewards were removed post-Merge, there is no point not using the wildcard here (and below)
Wodann
commented
May 1, 2024
| @@ -145,6 +145,9 @@ impl From<ExecutableTransaction> for TxEnv { | |||
| access_list: Vec::new(), | |||
| blob_hashes: Vec::new(), | |||
| max_fee_per_blob_gas: None, | |||
| // https://github.com/NomicFoundation/edr/issues/427 | |||
There was a problem hiding this comment.
This is a potential prague feature, which we don't support yet.
agostbiro
reviewed
May 2, 2024
agostbiro
approved these changes
May 2, 2024
Yes, let's wait 👍 |
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm okay waiting to merge this until after benchmarks are re-enabled. I'm curious to see whether performance is at all affected by changes in
revm