fix: avoid panic when using smock #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd96964 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agostbiro
changed the title
agostbiro
commented
May 2, 2024
crates/edr_napi/package.json
Outdated
| "test": "pnpm tsc && mocha --recursive \"test/**/*.ts\"", | ||
| "testNoBuild": "pnpm tsc && mocha --recursive \"test/**/*.ts\"", | ||
| "pretestArtifact": "pnpm install && pnpm tsc && npx hardhat compile", | ||
| "testArtifact": "mocha --recursive \"test/**/*.ts\" --timeout 60000", |
There was a problem hiding this comment.
timeout 60000, because these tests are ran with QEMU in the CI which is slow
Wodann
approved these changes
May 2, 2024
agostbiro
added a commit
that referenced
this pull request
May 6, 2024
Co-authored-by: Franco Victorio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smock.fakemakes EDR panic with the current released version due to a mismatch between TypeScript and Rust types. In TS the return type of the call override callback isPromise<T>, but in Rust we expectTwhich causes a panic.This PR fixes the conversion issue and adds a test for it.