Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support input as alias in eth_call and eth_sendTransaction #444

Merged
merged 3 commits into from
May 13, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented May 10, 2024

Resolves #360

@Wodann Wodann self-assigned this May 10, 2024
Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 263bcef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark May 10, 2024 22:25 — with GitHub Actions Inactive
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Do you wanna review @fvictorio ? Otherwise we can merge

@fvictorio fvictorio temporarily deployed to github-action-benchmark May 13, 2024 07:09 — with GitHub Actions Inactive
@fvictorio fvictorio merged commit c5da529 into main May 13, 2024
32 checks passed
@fvictorio fvictorio deleted the feat/tx-input branch May 13, 2024 09:54
@Wodann Wodann added this to the EDR v0.3.8 milestone May 21, 2024
konradkonrad added a commit to shutter-network/rolling-shutter that referenced this pull request Jul 2, 2024
Since upgrading to `[email protected]` the `play` tests were not
compatible anymore (see
#422). On
hardhats side, the problem was addressed in
NomicFoundation/edr#444.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support input in tx objects in addition to data
3 participants