fix: split code from remote account in #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af0f984 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
fvictorio
approved these changes
Jun 17, 2024
| @@ -118,6 +104,30 @@ impl State for CachedRemoteState { | |||
| } | |||
| } | |||
|
|
|||
| /// Fetches an account from the remote state. If it exists, code is split off | |||
| /// and stored separately in the provided cache. | |||
| fn fetch_remote_account( | |||
There was a problem hiding this comment.
Out of curiosity, why make this a separate function instead of making it a method of CachedRemoteState?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503