Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflow for testing Optimism every night #649

Merged
merged 1 commit into from
Sep 12, 2024
Merged

ci: add workflow for testing Optimism every night #649

merged 1 commit into from
Sep 12, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Sep 6, 2024

This workflow needs to be added to main as the schedule trigger only works on the default branch.

Original PR: #638

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Sep 6, 2024
@Wodann Wodann requested a review from a team September 6, 2024 15:05
@Wodann Wodann self-assigned this Sep 6, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0cb5d24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark September 6, 2024 15:05 — with GitHub Actions Inactive
@Wodann Wodann linked an issue Sep 9, 2024 that may be closed by this pull request
Add CI job for replaying Optimism blocks every night #630
Closed
fvictorio
fvictorio reviewed Sep 10, 2024
View reviewed changes
.github/workflows/test-recent-optimism-block.yml Outdated

defaults:
run:
working-directory: packages/hardhat-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this in the previous PR, but is this correct? Seems like a copy-paste leftover.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Addressed in follow-up commits

@Wodann Wodann temporarily deployed to github-action-benchmark September 11, 2024 23:26 — with GitHub Actions Inactive
@Wodann
ci: add workflow for testing Optimism every night
0cb5d24 
This workflow needs to be added to main as the
schedule trigger only works on the default branch.
@Wodann Wodann temporarily deployed to github-action-benchmark September 12, 2024 18:59 — with GitHub Actions Inactive
@Wodann Wodann added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 2e5ff9d Sep 12, 2024
17 checks passed
@Wodann Wodann deleted the ci/main-optimism-schedule branch September 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio approved these changes

Assignees

@Wodann Wodann

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI job for replaying Optimism blocks every night
2 participants
@Wodann @fvictorio