test: add isolate mode JS integration test

[agostbiro]

There is a Rust Solidity test runner integration test that tests that the isolate flag works by checking the gas report. I copied the same test i to the JS integration test to make sure that the enabling isolate mode works from JS as well.

I've also abstracted out the JS Solidity test runner integration test context to be able to be used from multiple test source files.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c372165

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[fvictorio]

I understand that the test contract is a copy of an existing solidity test, but I think we can do something much simpler, if we only care about testing that isolate mode is enabled:

contract IsolateTest is Test {
    StorageLib storageLib;

    function setUp() public {
        storageLib = new StorageLib();
    }

    function testIsolateTest() public {
        // tstore key: 1 with value :2
        storageLib.tstore(1, 2);

        // toload key: 1
        uint256 val = storageLib.tload(1);

        // If the test is run with `--isolate` flag, the value should be 0
        // as --isolate run each top level call as seperate transaction, so tload will return 0
        assertEq(val, 0, "did you forget to use --isolate flag for 'forge test'?");
    }
}

contract StorageLib {
    function tstore(uint256 key, uint256 val) public {
        assembly {
            tstore(key, val)
        }
    }

    function tload(uint256 key) public view returns (uint256 val) {
        assembly {
            val := tload(key)
        }
        return val;
    }
}

(copied from https://github.com/pancakeswap/pancake-v4-core/blob/857b4bf8055e74465900b5c15997fa100ee3044a/test/Isolate.t.sol)

I'd rather use this simpler version because it's easier to understand what is testing and why it works.

[fvictorio]

Normally a static async constructor means a private constructor, unless you want to allow creating instances directly too.

[agostbiro]

Thanks fixed in 4f96f26

[agostbiro]

@fvictorio thanks fixed here: Simplify isolate mode test and add inverse test

[fvictorio]

Let's add a mention here that this was taken from the Pancakeswap repo.

[fvictorio]

Minor comment, feel free to merge after fixing that.