Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove foundry config and linking crates #670

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor: remove foundry config and linking crates #670

merged 1 commit into from
Sep 17, 2024

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Sep 17, 2024 •
edited
Loading

  • Remove foundry-linking and move contents to forge integration test helpers
  • Remove foundry-config and distribute contents to
    • edr_defaults
    • forge integration test helpers
    • cheatcode configs to foundry-cheatcodes
  • Remove some further unused code

There are no changes in functionality beyond reorganization.

@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Sep 17, 2024
@agostbiro agostbiro added this to the Solidity tests, phase 2 milestone Sep 17, 2024
@agostbiro agostbiro requested a review from a team September 17, 2024 17:10
@agostbiro agostbiro self-assigned this Sep 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6852b79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from refactor/remove-debugger to feat/solidity-tests September 17, 2024 17:12
Xanewok
Xanewok approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the code around looks good 👍

@agostbiro agostbiro temporarily deployed to github-action-benchmark September 17, 2024 17:13 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 17, 2024 17:13 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit 058cbf6 into feat/solidity-tests Sep 17, 2024
37 of 38 checks passed
@agostbiro agostbiro deleted the refactor/remove-crates branch September 17, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
EDR
Status: Done
Milestone
Solidity tests, phase 2
Development

Successfully merging this pull request may close these issues.
2 participants
@agostbiro @Xanewok