Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up foundry_common and rename crates #672

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Sep 19, 2024

The PR is split into two commits:

refactor: clean up foundry_common

  • Remove further unused code.
  • Move constants from foundry_common to edr_defaults if used in multiple creates or to the specific crate where they're used.
  • Move provider from foundry_common to foundry_evm_core::fork.
  • Move contracts from foundry_common to foundry_evm_core::contracts.
  • Move formatters from foundry_common to foundry_evm_core::abi::fmt. These formatters are primarily used in foundry_evm_core::abi.
  • Move test helpers from edr_test_utils to forge integration test helpers if they're only needed there.
  • Move test helpers from foundry_common to forge integration test helpers if they're are only needed there

refactor: rename crates

  • Rename foundry-common to edr_common. This contains math and filesystem utilities now.
  • Rename foundry-macros to edr_macros for proc macros.
  • Rename forge to edr_solidity_tests and move integration test suite data into the crate.

@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Sep 19, 2024
@agostbiro agostbiro added this to the Solidity tests, phase 2 milestone Sep 19, 2024
@agostbiro agostbiro requested a review from a team September 19, 2024 18:48
@agostbiro agostbiro self-assigned this Sep 19, 2024
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 4527fd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro temporarily deployed to github-action-benchmark September 19, 2024 18:48 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 19, 2024 20:22 — with GitHub Actions Inactive
Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming together nicely!

@agostbiro agostbiro temporarily deployed to github-action-benchmark September 20, 2024 10:55 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 20, 2024 10:55 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit fc38cb4 into feat/solidity-tests Sep 20, 2024
38 checks passed
@agostbiro agostbiro deleted the refactor/cleanup-crates branch September 20, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants