Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: REVM to latest version with minimal forking #677

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Sep 24, 2024

Upgrade REVM to the latest version that requires minimal changes. At this point we only need a modification to revert to Rust v1.80.

A large restructuring of crates was performed in REVM that required changes to our re-exports. I tried to structure it in a way that would minimise future impact of reorganisations in REVM.

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Sep 24, 2024
@Wodann Wodann self-assigned this Sep 24, 2024
Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: e5e0c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark September 24, 2024 07:42 — with GitHub Actions Inactive
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 65.61743% with 142 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/multichain@8603cfd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/edr_napi/src/chains/l1.rs 0.00% 19 Missing ⚠️
crates/edr_optimism/src/transaction/request.rs 0.00% 14 Missing ⚠️
crates/edr_provider/src/data.rs 63.63% 12 Missing ⚠️
crates/edr_napi_core/src/logger.rs 0.00% 10 Missing ⚠️
...ates/edr_provider/src/requests/eth/transactions.rs 50.00% 8 Missing and 2 partials ⚠️
crates/edr_provider/src/requests/eth/state.rs 22.22% 7 Missing ⚠️
crates/edr_evm/src/receipt.rs 80.00% 6 Missing ⚠️
crates/edr_provider/src/requests/validation.rs 78.57% 3 Missing and 3 partials ⚠️
crates/edr_evm/src/state.rs 82.60% 4 Missing ⚠️
crates/edr_provider/src/requests/eth/gas.rs 63.63% 4 Missing ⚠️
... and 24 more
Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/multichain     #677   +/-   ##
==================================================
  Coverage                   ?   53.35%           
==================================================
  Files                      ?      236           
  Lines                      ?    27703           
  Branches                   ?    27703           
==================================================
  Hits                       ?    14780           
  Misses                     ?    12005           
  Partials                   ?      918           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann marked this pull request as ready for review September 24, 2024 17:49
@Wodann Wodann requested a review from a team September 24, 2024 17:52
@Wodann Wodann temporarily deployed to github-action-benchmark September 24, 2024 18:02 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark September 25, 2024 16:12 — with GitHub Actions Inactive
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Wodann Wodann merged commit d2f663d into feat/multichain Sep 25, 2024
41 checks passed
@Wodann Wodann deleted the build/latest-revm branch September 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants