fix: range create error

[kanej]

If the import completion is triggered by deleting a quote on an existing import and readding it then, the position is the start of the import but we delete the entire length of the import line which creates a negative position triggering the bug.

Instead, we short circuit. If the import is already the suggestion we don't suggest it again.

Fixes #150.

[antico5]

@kanej should I rebase and merge this ?

[kanej]

@kanej should I rebase and merge this ?

Can you rebase this. I added this as a draft as I stumbled over the recreation steps for it while testing something else. I quickly put together a fix while it was fresh in my mind - but without the time to work through in detail.

So the current state is, we can reproduce the range create error bug with the steps in the descriptions. I have what appears to be a fix.

Basically, I think the next steps are:

1. Recreate locally
2. Figure out how we should fix this properly (reuse this draft if useful or ignore otherwise)
3. Test and review as normal

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.49%. Comparing base (e5372f3) to head (058680e).

Files with missing lines	Patch %	Lines
...ver/src/frameworks/Hardhat/getImportCompletions.ts	0.00%	5 Missing ⚠️
...src/services/completion/getImportPathCompletion.ts	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #584      +/-   ##
===============================================
- Coverage        54.52%   54.49%   -0.04%     
===============================================
  Files              226      226              
  Lines             5199     5202       +3     
  Branches           800      801       +1     
===============================================
  Hits              2835     2835              
- Misses            2127     2129       +2     
- Partials           237      238       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[antico5]

@kanej just rebased and reproduced the original issue. Your PR effectively solves the problem, so it's good to go on our merge backlog