Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#534): platform specific builds of vsix #612

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

feat(#534): platform specific builds of vsix #612

wants to merge 3 commits into from

Conversation

gordon-to
Copy link

@gordon-to gordon-to commented Nov 14, 2024 •
edited
Loading

Create platform specific vsix builds. closes #534.

  • Updated .github/workflows/ci.yaml
    • update cache action to v4
    • add arch and platform to matrix
    • set TARGET env var to platform-arch
  • Update client/package.json to use TARGET env var in vsce package command

based on https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml

OmarTawfik and others added 2 commits September 25, 2024 18:42
@OmarTawfik
Delete .github/workflows/add-issue-to-project.yml (NomicFoundation#599)
5dffc44 
> With respect to the failing CI, I recommend removing that workflow and using GitHub Projects's native way of automatically adding issues to projects. That can be done in a separate PR though.

I think @kanej added it. I'm happy to remove it if you don't think it is useful anymore?

_Originally posted by @OmarTawfik in NomicFoundation#598 (comment)
@braveocheretovych @kanej
Docs: Changing the name and link to the social network
ba13b37 
Hello. Changing the name and link to the social network in the documentation
@socket-security Socket Security
Copy link

socket-security bot commented Nov 14, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +4 833 kB chai
npm/[email protected] environment, filesystem, shell +4 550 kB thomasrockhu
npm/[email protected] environment, filesystem +1 6.97 MB gustavohenke
npm/[email protected] environment Transitive: filesystem, shell +1 50.3 kB kentcdodds
npm/[email protected] environment, filesystem 0 36.6 kB motdotla
npm/[email protected] environment, filesystem, network, shell +1 8.07 MB evanw
npm/[email protected] None 0 18.2 kB lydell
npm/[email protected] filesystem, unsafe Transitive: environment, network +28 3.28 MB ljharb
npm/[email protected] filesystem Transitive: environment, eval, shell, unsafe +25 7.29 MB eslintbot
npm/[email protected] filesystem +4 188 kB mrmlnc
npm/[email protected] None 0 63.3 kB ryanzim
npm/[email protected] filesystem, network +15 529 kB sindresorhus
npm/[email protected] environment, filesystem, network, shell Transitive: eval +26 125 MB kanej

View full report↗︎

@gordon-to gordon-to marked this pull request as ready for review November 14, 2024 11:28
@antico5
Copy link
Collaborator

antico5 commented Feb 25, 2025

@gordon-to Apologize for the long delay. Could you explain why we need platform-specific vsix files? we always distributed a single package through the vscode marketplace that should work on all supported platforms.

@gordon-to
Copy link
Author

It reduces download size for each platform and there are native bindings in this exension. Slang should also fix its package.json so that these dependencies are only installed on the correct cpu/arch

2.3M ./@nomicfoundation/slang-linux-arm64-gnu
2.3M ./@nomicfoundation/slang-linux-arm64-musl
2.7M ./@nomicfoundation/slang-linux-x64-gnu
2.7M ./@nomicfoundation/slang-linux-x64-musl
2.9M ./@nomicfoundation/slang-darwin-arm64
2.9M ./@nomicfoundation/slang-win32-ia32-msvc
3.3M ./@nomicfoundation/slang-win32-arm64-msvc
3.4M ./@nomicfoundation/slang-darwin-x64
3.9M ./@nomicfoundation/slang-win32-x64-msvc

@antico5
Copy link
Collaborator

antico5 commented Feb 28, 2025

Thanks for the contribution. We are about to release a new version that uses Slang 0.19 (check this PR) , which uses wasm instead of native extensions, so the package size will be greatly reduced. We can revisit this PR after the upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:triaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create platform specific builds of the vsix
4 participants
@gordon-to @antico5 @OmarTawfik @braveocheretovych