Network Manager M1 remaining tasks

[schaable]

This PR addresses most of the tasks outlined in this document, except for the "Types" section, which will be addressed in a separate PR. I suggest reviewing one commit at a time for an easier review process.

Summary:

• Added tests for:
  • All config hooks (extendUserConfig, validateUserConfig, resolveUserConfig).
  • HTTPProvider: jsonRpcWrapper and close functions.
  • NetworkManager: connect function and all network hooks (newConnection, closeConnection, onRequest).
  • NetworkConnection: class initialization and close function (through NetworkManager)
• Fixed bugs found during testing.
• Refactored code for better readability and to facilitate testing.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 5:23pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: ae00903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[schaable]

The interesting thing is that this validation uses conditionalUnionType behind the scenes, so it might be bugged as well.

[alcuadrado]

I think this is working as intended concerning the conditionalUnionType. Its main idea is to return errors that are as specific as possible.

unionType does the contrary. It always returns a less specific error message.

Maybe for this particular case we should use unionType.

[schaable]

the problem is that unionType expects the first argument to be an array of zod types, and we're using isObject in sensitiveUrlType. Maybe we could replace it with z.object() or z.record(), but we'd need to make it generic.

[schaable]

I've updated sensitiveUrlType and sensitiveStringType to use unionType (and renamed them to schemas). However, there's a bug in Zod that prevents the union from using the provided errorMap when the string schema is z.string().url() (and likely other validations). See:

hardhat/v-next/hardhat-zod-utils/src/index.ts

Lines 156 to 160 in ae00903

	* TODO: The custom error message in the unionType function doesn't work
	* correctly when using string().url() for validation, see:
	* https://github.com/colinhacks/zod/issues/2940
	* As a workaround, we provide the error message directly in the url() call.
	* We should remove this when the issue is fixed.

[alcuadrado]

I left a few comments, but LGTM