Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the EDR Network user config validation #5888

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix the EDR Network user config validation #5888

merged 1 commit into from
Oct 29, 2024

Conversation

alcuadrado
Copy link
Member

Just a small PR fixing a zod schema that was too restrictive.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 7f3eaa9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 6:42pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 29, 2024
schaable
schaable reviewed Oct 29, 2024
View reviewed changes
v-next/hardhat/src/internal/builtin-plugins/network-manager/type-validation.ts
gas: userGasSchema,
gasMultiplier: z.number(),
gasPrice: userGasSchema,
from: z.optional(z.string()).optional(),
Copy link
Member

@schaable schaable Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be redundant

schaable
schaable approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, but lgtm!

@alcuadrado alcuadrado added this pull request to the merge queue Oct 29, 2024
Merged via the queue into v-next with commit b57e1f3 Oct 29, 2024
48 checks passed
@alcuadrado alcuadrado deleted the edr-validation-fix branch October 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaable schaable schaable approved these changes

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcuadrado @schaable