Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viem types improvements #6239

Closed
wants to merge 7 commits into from
Closed

Viem types improvements #6239

wants to merge 7 commits into from

Conversation

alcuadrado
Copy link
Member

An initial round of improvements to the viem types and chain handling. This is not complete, but enough for the alpha.

@alcuadrado alcuadrado requested a review from schaable February 8, 2025 15:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2cf1656

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:03pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 8, 2025
@kanej kanej linked an issue Feb 10, 2025 that may be closed by this pull request
Viem Type improvements for Public Alpha #6242
Closed
schaable
schaable approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alcuadrado alcuadrado added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 10, 2025
@alcuadrado alcuadrado added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 11, 2025
@alcuadrado alcuadrado force-pushed the viem-types-improvements branch from 82f399c to 4a84fa4 Compare February 11, 2025 16:52
@alcuadrado alcuadrado force-pushed the viem-types-improvements branch from 4a84fa4 to 2cf1656 Compare February 11, 2025 17:02
@kanej kanej added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 11, 2025
@alcuadrado alcuadrado added this pull request to the merge queue Feb 11, 2025
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 12, 2025
@schaable schaable added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 12, 2025
@alcuadrado
Copy link
Member Author

Replaced by #6268 and #6266

Thanks @schaable!

@alcuadrado alcuadrado closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaable schaable schaable approved these changes

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viem Type improvements for Public Alpha
2 participants
@alcuadrado @schaable