Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up codecov for the hardhat repository #6449

Draft
wants to merge 13 commits into
base: v-next
Choose a base branch
from

Conversation

galargh
Copy link
Member

@galargh galargh commented Mar 5, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR sets up Codecov for the Hardhat repository. It will allow us to track the following over time:

  • unit test coverage
  • test flakiness (beta)
  • bundle size (with an asset breakdown)

The Codecov integration will also comment on PRs highlighting the changes to the above metrics in relation to the target branch.

⚠️ In this PR, I also remove our custom bundle comments. Instead, we'll rely on Codecov's bundle analysis. There is a slight regression as the comment from Codecov about the bundle size will not include the information about the number of dependencies. This information will only be available after clicking through to the bundle analysis details, also present in the comment. In my opinion, this is acceptable. Especially since, the codecov integration will allow us to track bundle size over time, something we didn't do before.

⚠️ Please note that the coverage tracking does not currently work for the ignition packages. After discussing this internally, I decided not to fix it now since the ignition packages are soon to be migrated to node test runner anyway. This migration will likely come with the coverage support out of the box.

TODO

*Alternatively, we can set up the CODECOV_TOKEN for the entire organization by copying it from the Codecov Organization Configuration and adding the CODECOV_TOKEN secret to the Organization Secrets

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: afe84ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:55pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Mar 5, 2025
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant