Merged
Conversation
Contributor
erwan-joly
commented
Nov 15, 2025
erwan-joly
commented
- Updated target framework from net8.0 to net10.0 in main project
- Updated target framework from net8.0 to net10.0 in test project
- Updated GitHub Actions workflow to use .NET 10.0.x
- Updated target framework from net8.0 to net10.0 in main project - Updated target framework from net8.0 to net10.0 in test project - Updated GitHub Actions workflow to use .NET 10.0.x
Main project: - DotNetty.* packages: 0.7.5 -> 0.7.6 - NodaTime: 3.1.9 -> 3.2.0 Test project: - ApprovalTests: 6.0.0 -> 7.0.0 - coverlet.collector: 6.0.0 -> 6.0.2 - Microsoft.AspNet.WebApi.Client: 6.0.0 -> 6.0.2 - Microsoft.NET.Test.Sdk: 17.8.0 -> 17.12.0 - Moq: 4.20.69 -> 4.20.72 - MSTest.TestAdapter: 3.1.1 -> 3.6.3 - MSTest.TestFramework: 3.1.1 -> 3.6.3 - NodaTime.Testing: 3.1.9 -> 3.2.0
- Updated actions/checkout from v2 to v4 - Updated actions/setup-dotnet from v3 to v4 - Replaced deprecated set-output commands with $GITHUB_OUTPUT - Replaced deprecated actions/upload-release-asset@v1 with softprops/action-gh-release@v2 - Removed obsolete jossef/action-latest-release-info dependency - Fixed GITHUB_TOKEN reference to use secrets.GITHUB_TOKEN
- Replaced Assert.IsTrue with SequenceEqual with CollectionAssert.AreEqual - This is the recommended approach for comparing collections in MSTest - Removed unused System.Linq using statement
- Removed CS1591 warning suppression from project file - Added XML documentation comments to all 27 source files - Documented 140+ public types, methods, properties, and constructors - Includes summary tags, param tags, and returns tags - Documentation follows best practices for API consumers This enables proper IntelliSense support and API documentation generation.
The comprehensive XML documentation is valuable but not required for build success. Restoring NoWarn to allow builds without documentation warnings.
- Fixed typo in test csproj: TreatWrningsAsErrors -> TreatWarningsAsErrors - Removed unused Castle.Core.Logging import from SpanRequestFilterTest.cs These fixes ensure warnings are properly treated as errors and clean up unused dependencies.
- Explicitly specify .NET 10.0.0 version - Add manual installation fallback using dotnet-install.sh - This handles cases where setup-dotnet@v4 doesn't have .NET 10 yet .NET 10 was just released on Nov 11, 2025, so it may not be in the setup-dotnet action's manifest yet. This ensures the workflow succeeds regardless.
- Microsoft.NET.Test.Sdk: 17.12.0 → 18.0.1 - MSTest.TestAdapter: 3.6.3 → 4.0.2 - MSTest.TestFramework: 3.6.3 → 4.0.2 - coverlet.collector: 6.0.2 → 6.0.4 All packages updated to versions released on or after November 11, 2025, ensuring full compatibility with .NET 10.
- Fixed Microsoft.AspNet.WebApi.Client: 6.0.2 (doesn't exist) → 6.0.0 - Added Microsoft.IdentityModel.JsonWebTokens 8.14.0 to fix GHSA-59j7-ghrg-fj52 vulnerability - Added System.IdentityModel.Tokens.Jwt 8.14.0 to fix GHSA-59j7-ghrg-fj52 vulnerability These explicit package references override the vulnerable 7.0.3 versions that were coming in as transitive dependencies.
- MSTEST0001: Enable test parallelization at method level - MSTEST0044: Replace obsolete DataTestMethod with TestMethod (2 occurrences) MSTest 4.0 requires explicit parallelization configuration and no longer uses DataTestMethod - TestMethod with DataRow attributes is the new pattern.
- Removed invalid AssemblyAttribute from csproj - Created AssemblyInfo.cs with proper Parallelize attribute - This fixes MSB3715 error where ExecutionScope type was not found MSTest 4.0 requires assembly-level parallelization to be configured via code, not project file attributes.
erwan-joly
deleted the
claude/upgrade-dotnet-10-01BcetFyyVBD62HhVeqkRVdU
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.