-
-
Notifications
You must be signed in to change notification settings - Fork 160
cmake, arduino and glsl support #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.8
Are you sure you want to change the base?
Conversation
0db94bb
to
49cddc5
Compare
5ab9f44
to
8cbebb0
Compare
addressed all the remaining comments I also dug a bit into the arduino-cli sources and found that the config path has actually been the last change is making |
cmd = | ||
[ | ||
(getExe pkgs.arduino-language-server) | ||
"-clangd" | ||
( | ||
if cfg.lsp.clangdPackage == null | ||
then "clangd" | ||
else getExe' cfg.lsp.clangdPackage "clangd" | ||
) | ||
"-cli" | ||
( | ||
if cfg.lsp.cliPackage == null | ||
then "arduino-cli" | ||
else getExe cfg.lsp.cliPackage | ||
) | ||
"-cli-config" | ||
cfg.lsp.cliConfigPath | ||
"-fqbn" | ||
cfg.lsp.fqbn | ||
] | ||
++ cfg.lsp.extraArgs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd = | |
[ | |
(getExe pkgs.arduino-language-server) | |
"-clangd" | |
( | |
if cfg.lsp.clangdPackage == null | |
then "clangd" | |
else getExe' cfg.lsp.clangdPackage "clangd" | |
) | |
"-cli" | |
( | |
if cfg.lsp.cliPackage == null | |
then "arduino-cli" | |
else getExe cfg.lsp.cliPackage | |
) | |
"-cli-config" | |
cfg.lsp.cliConfigPath | |
"-fqbn" | |
cfg.lsp.fqbn | |
] | |
++ cfg.lsp.extraArgs; | |
cmd = | |
[ | |
(getExe pkgs.arduino-language-server) | |
"-clangd" | |
(getExe' pkgs.clang-tools "clangd") | |
"-cli" | |
(getExe pkgs.arduino-cli) | |
"-cli-config" | |
"$HOME/.arduino15/arduino-cli.yaml" | |
"-fqbn" | |
cfg.lsp.fqbn | |
]; |
@NotAShelf @Soliprem I need a second opinion, should cfg.lsp.clangdPackage
and friends be added here, or should we remove them and let users configure via vim.lsp.servers
?
since cfg.lsp.fqbn
is required, I think we'll need to keep it regardless if the others get removed
8b98f07
to
ba9ce8b
Compare
rebased #1019 on
v0.8
and added cmake and glslSanity Checking
nix fmt
).#nix
(default package).#maximal
.#docs-html
(manual, must build).#docs-linkcheck
(optional, please build if adding links)x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.