Update lib.types.dagOf implementation to use payload
#1163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the more modern approach: NixOS/nixpkgs#375084 The above PR does this for similar cases in nixpkgs. This fixes a warning that shows up when using the lib in weird ways: ``` trace: evaluation warning: The deprecated `functor.wrapped` attribute is accessed, use `nestedTypes.elemType` instead. ``` The warning is thrown by the module system when merging types (at least in some cases). It shouldn't be exposed at all in the current codebase.
alfarelcynthesis
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
|
I'm sorry I never got the notification for this PR. Looks like I inadvertently superseded this in #1209 so your feedback would be appreciated :) |
|
This was honestly just me fixing the one source of the warnings you mention in #1209 that I could find (which is why I never bothered re-pinging for it), thanks for actually fixing the issue I was running into. I initially ran into the warnings when setting up a configurable default for the keymap option functions, so I'll look into that again (for disabling all nvf keymaps) at some point and let you know if all the warnings are gone, since I don't know the actual merge semantics, and since #1209 is already merged. In either case, this PR isn't necessary, so I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nixpkgs is in the process of migrating some of it's type merging code: NixOS/nixpkgs#375084.
This migrates the one instance of
wrapperI could find in nvf's lib.This isn't particularly urgent since it won't throw any warnings unless the lib is being merged as part of a module system, which would be a very strange usecase for an external consumer.
This could be easily rebased to target
main, if that would be preferred.Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.