-
-
Notifications
You must be signed in to change notification settings - Fork 191
languages/ts: add vtsls support for vue #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
horriblename
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Head branch was pushed to by a user without write access
f528a7a to
ea7f4ee
Compare
| }; | ||
| }; | ||
|
|
||
| config = mkIf cfg.enable (mkMerge [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should probably be a
mkIf cfg.extraVueSupport {
vim.languages.ts.lsp.servers = ["vtsls"];
};
| _file = ./ts.nix; | ||
| options.vim.languages.ts = { | ||
| enable = mkEnableOption "Typescript/Javascript language support"; | ||
| extraVueSupport = mkEnableOption "Vue support for vtsls"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NotAShelf should vue be in it's own language module? since astro/svelte has their own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main argument for having it in the typescript model is because: "Since v3.0.0, the Vue language server requires vtsls to support TypeScript." (source).
Both astro and svelte have their standalone LSPs because they deviate from regular ts / tsx so much.
This adds vtsls - a typescript lsp that also works with vue.
I also added a switch if you want to install the vue grammar or not since vtsls works as a standalone ts lsp as well.
This is my first PR to any FOSS project so bear with me
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.