Skip to content

Conversation

@venkyr77
Copy link
Contributor

@venkyr77 venkyr77 commented Apr 5, 2025

This PR adds auto-save.nvim

Testing:

Tested my changes by changing the nvf url to the branch from my fork

nvf.url = "github:venkyr77/nvf/auto-save-init";

with config.vim.auto-save.enable = false,

before

with config.vim.auto-save.enable = true,

after

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Apr 5, 2025
@github-actions
Copy link

github-actions bot commented Apr 5, 2025

🚀 Live preview deployed from e2b3daa

View it here:

Debug Information

Triggered by: venkyr77

HEAD at: auto-save-init

Reruns: 625

Soliprem

This comment was marked as outdated.

@NotAShelf
Copy link
Owner

@Soliprem additions to configuration.nix for new plugins is not a hard requirement. It is nice to provide reference, but that is not why we have the default packages.

On this note, I am a little unhappy with the design of current file. We are mindlessly dumping options to a single file and increasing eval time. Once I migrate documentation to ndg v2, I will reconsider a solution.

@Soliprem
Copy link
Collaborator

Soliprem commented Apr 7, 2025

Sounds good, was about to send you a DM on this exact topic. I'll approve as soon as I get on my laptop then

@venkyr77 venkyr77 requested a review from Soliprem April 9, 2025 21:30
@Soliprem
Copy link
Collaborator

my apologies @venkyr77 this slipped my mind (feel free to @me in the future). If you fix the conflict with release-notes I'll be happy to approve the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants