Skip to content

Conversation

@venkyr77
Copy link
Contributor

@venkyr77 venkyr77 commented Apr 6, 2025

This PR adds fish language support

Fixes #792

Testing:

Tested my changes by changing the nvf url to the branch from my fork

nvf.url = "github:venkyr77/nvf/fish-lsp";

with config.vim.languages.fish.treesitter.enable = false,

image

with config.vim.languages.fish.treesitter.enable = true,

image

with config.vim.languages.fish.lsp.enable = false,

image

with config.vim.languages.fish.lsp.enable = true,

image

with config.vim.languages.fish.format.enable = false,

:ConformInfo shows

Formatters for this buffer:
LSP: fish_lsp

with config.vim.languages.fish.format.enable = true,

:ConformInfo shows

Formatters for this buffer:
LSP: fish_lsp
fish_indent ready (fish) /nix/store/j2qz2d900y518k2hq6myl60g2vyh7l19-fish-4.0.1/bin/fish_indent

after :lua require("conform").format(),

image

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Apr 6, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

🚀 Live preview deployed from 585dfca

View it here:

Debug Information

Triggered by: venkyr77

HEAD at: fish-lsp

Reruns: 648

@venkyr77 venkyr77 mentioned this pull request Apr 6, 2025
1 task
@NotAShelf
Copy link
Owner

We're currently not accepting new language modules into main, as all language modules are in the process of being refactored. Please consider rebasing on the lsp-redesign branch once it is complete in terms of implementation.

@venkyr77
Copy link
Contributor Author

venkyr77 commented Apr 9, 2025

We're currently not accepting new language modules into main, as all language modules are in the process of being refactored. Please consider rebasing on the lsp-redesign branch once it is complete in terms of implementation.

That makes sense, let me keep the PR in draft state till then so it doesn't clutter the active PRs to look into

@venkyr77 venkyr77 marked this pull request as draft April 9, 2025 21:29
@nil-andreas nil-andreas mentioned this pull request May 17, 2025
17 tasks
@imnotpoz imnotpoz mentioned this pull request Jul 19, 2025
17 tasks
@poseidon-rises
Copy link
Contributor

Just FYI, you can now rebase this on the v0.8 branch, although I will happily take this on if you don't plan on doing it.

@poseidon-rises poseidon-rises mentioned this pull request Aug 25, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fish-lsp

3 participants