languages/emmet: add module #867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bliztle
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
|
Should I add emmet to |
|
The |
|
eslint is used by ts, astro, etc. and we didn't add a dedicated filetype for eslint. I don't think we need a separate "language" for emmet. @NotAShelf should we split off conform/nvim-lint/lsp configuration from languages? the JS family has a fuck TON of duplication in their code (astro, svelte, ts, and possibly more) |
|
✅ Preview has been deleted successfully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added emmet lsp for html shorthand completions such as div>ul>li*3. This only adds a single, simple language module, contained to a single file.
I briefly considered if this should have been added as an extension to vim.languages.html, but decided on making it its own module since it also integrates with jsx and other html-like frontend frameworks. I have no strong feelings about his however.
If there is anything I've missed or need to change please do tell, and I will happily see to it!
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.