-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Babel and coveralls #49
Open
YasharF
wants to merge
3
commits into
Nubescope:master
Choose a base branch
from
YasharF:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2019
ES2015 features are now in the LTS versions of NodeJS, and there is no longer a need to use Babel to gain access to those features
Hi @YasharF, thanks again! |
Sure, I can try to help. |
gaguirre
reviewed
Apr 30, 2019
gaguirre
previously approved these changes
May 9, 2019
@YasharF you're admin now, so you can merge the PR once approved 👍 |
YasharF
force-pushed
the
master
branch
2 times, most recently
from
May 9, 2019 20:51
36415e0
to
1561fdd
Compare
I added 1561fdd not realizing that it is going to make the review process to have to restart. |
YasharF
force-pushed
the
master
branch
2 times, most recently
from
May 29, 2019 12:43
11c21ad
to
2e3ed74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES2015 features that Babel was used for are now in LTS versions of NodeJS.
There is no near term plan to significantly improve the code coverage and the gulp-coveralls npm module is not actively maintained.