Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Babel and coveralls #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

YasharF
Copy link
Contributor

@YasharF YasharF commented Apr 22, 2019

ES2015 features that Babel was used for are now in LTS versions of NodeJS.
There is no near term plan to significantly improve the code coverage and the gulp-coveralls npm module is not actively maintained.

ES2015 features are now in the LTS versions of NodeJS, and there is no longer a need to use Babel to gain access to those features
@gaguirre
Copy link
Collaborator

Hi @YasharF, thanks again!
Would you like to be maintainer of sinon-mongoose? So you don't depend on me to make new changes.

@YasharF
Copy link
Contributor Author

YasharF commented Apr 30, 2019

Sure, I can try to help.

gulpfile.js Show resolved Hide resolved
gaguirre
gaguirre previously approved these changes May 9, 2019
@gaguirre
Copy link
Collaborator

gaguirre commented May 9, 2019

@YasharF you're admin now, so you can merge the PR once approved 👍

@YasharF
Copy link
Contributor Author

YasharF commented May 15, 2019

I added 1561fdd not realizing that it is going to make the review process to have to restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants