Skip to content

chore - keep old priorities for temporary backwards compatibility #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

chore - keep old priorities for temporary backwards compatibility #174

merged 2 commits into from
May 6, 2025

Conversation

juicetin
Copy link
Member

@juicetin juicetin commented May 1, 2025 •
edited
Loading

Description

  • short term backwards compatibility to prevent forced updates to hyperdrive in services that may not be ready to yet, if their config file parser versions have the breaking changes (removing the old priority levels)

Test Plan

Please include steps to test the change. Include screenshots if applicable.

Checklist

  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@juicetin juicetin added the patch label May 1, 2025
@juicetin juicetin self-assigned this May 1, 2025
@juicetin juicetin marked this pull request as draft May 1, 2025 08:23
@juicetin juicetin force-pushed the chore/backwards-compatibility branch from 9619493 to 69bba9f Compare May 1, 2025 21:16
@juicetin
Copy link
Member Author

juicetin commented May 1, 2025

needed to fix conflicts, had an old version on my local when creating this branch

@juicetin juicetin marked this pull request as ready for review May 1, 2025 21:16
@juicetin juicetin added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit a2a0f6a May 6, 2025
6 checks passed
@juicetin juicetin deleted the chore/backwards-compatibility branch May 6, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-thacker-nullify tim-thacker-nullify tim-thacker-nullify approved these changes

@vik-nullify vik-nullify vik-nullify approved these changes

@jonathanlam jonathanlam Awaiting requested review from jonathanlam

Assignees

@juicetin juicetin

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juicetin @tim-thacker-nullify @vik-nullify