Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1: schema test coverage 100% #4468

Merged
merged 3 commits into from
Apr 10, 2025
Merged

3.1: schema test coverage 100% #4468

merged 3 commits into from
Apr 10, 2025

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 19, 2025 •
edited
Loading

Port of

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl added this to the v3.1.2 milestone Mar 19, 2025
@ralfhandl ralfhandl changed the title 3.1 schema test coverage 100% 3.1: schema test coverage 100% Mar 19, 2025
@ralfhandl ralfhandl marked this pull request as ready for review March 19, 2025 13:35
@ralfhandl ralfhandl requested review from a team as code owners March 19, 2025 13:35
@ralfhandl ralfhandl linked an issue Mar 19, 2025 that may be closed by this pull request
3.1 3.2 schemas: Link Object schema has body property instead of server #4463
Closed
miqui
miqui previously approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralfhandl looks good.

@ralfhandl ralfhandl requested review from miqui and a team March 24, 2025 11:19
@karenetheridge
Copy link
Member

Would it be useful to add a failing schema that uses the old property name (body)?

@ralfhandl
Copy link
Contributor Author

ralfhandl commented Mar 27, 2025 •
edited
Loading

Would it be useful to add a failing schema that uses the old property name (body)?

Good idea, the bug has been published quite a while ago.

Added tests/schema/fail/link-object-no-body.yaml.

@ralfhandl ralfhandl added Housekeeping approved pr port PRs that just port an approved PR to another version and removed Housekeeping labels Mar 28, 2025
@ralfhandl ralfhandl mentioned this pull request Mar 28, 2025
Open
@ralfhandl ralfhandl mentioned this pull request Apr 4, 2025
Open
@handrews
Copy link
Member

Latest commit adds the requested test case, so I'm going to approve and merge.

@handrews handrews merged commit e085227 into OAI:v3.1-dev Apr 10, 2025
2 checks passed
@ralfhandl ralfhandl deleted the 3.1-schema-test-coverage branch April 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

@miqui miqui Awaiting requested review from miqui

Assignees
No one assigned
Labels
approved pr port PRs that just port an approved PR to another version Schema
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

3.1 3.2 schemas: Link Object schema has body property instead of server
4 participants
@ralfhandl @karenetheridge @handrews @miqui