Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic status type when generating plot "OBO Principle by status" in analysis page #118

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

anitacaron
Copy link
Collaborator

@anitacaron anitacaron commented Jun 8, 2024

Fixes #85

The analysis.html page is now generated by a Python script instead of the jupyter notebook.

I tested with OMO, which has only PASS status(even though in the dashboard there's one WARN, but for this purpose, it's fine):

Screenshot 2024-06-08 at 19 38 04

Everything else is working the same, I just improved with refactoring some parts of the code in the jupyter notebook.

The plots are the same:

Screenshot 2024-06-08 at 19 35 47

The tables are looking a bit different:

Screenshot 2024-06-08 at 19 36 04

The node connections graph is there

Screenshot 2024-06-08 at 19 36 50

The code expected to have the four status types in the dashboard
results. This is not always the case, so the code was updated to check
for the available status types before reshaping the data.
The script processes the dashboard results and prepares it for analysis.
It generates plots and tables for the analysis page. The script replaces
the dashboard_analysis.ipynb Jupyter notebook with some improvements.
The analysis.html page is now generated by a python script instead of
the jupyter notebook.
@anitacaron anitacaron self-assigned this Jun 8, 2024
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG OMG!!!! This is sooo cooool!!! Thank you! Really much appreciated!!

(@rays22 for TWG report)

@anitacaron anitacaron merged commit bbca8cb into master Jun 10, 2024
1 check passed
Copy link

@souzadevinicius souzadevinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

pfabry added a commit to OBOFoundry/obo-nor.github.io that referenced this pull request Jun 11, 2024
@anitacaron anitacaron deleted the anitacaron/issue85 branch June 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline only works if there is one of each error types resulting from the ontologies in dashboard-config.yml
3 participants