Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] mail_template_substitute: Migration to 16.0 #1120

Merged
merged 10 commits into from
Aug 4, 2023
Merged

[16.0][MIG] mail_template_substitute: Migration to 16.0 #1120

merged 10 commits into from
Aug 4, 2023

Conversation

amkarthik
Copy link
Member

@amkarthik amkarthik commented Apr 3, 2023 •
edited
Loading

mail_template_substitute: Migration to 16.0

Depends on OCA/reporting-engine#700

sbejaoui and others added 9 commits March 31, 2023 12:37
@pedrobaeza
Copy link
Member

Wrong title name.

@amkarthik amkarthik changed the title [16.0][MIG] mass_mailing_list_dynamic: Migration to 16.0 [16.0][MIG] mail_template_substitute: Migration to 16.0 Apr 3, 2023
@amkarthik
Copy link
Member Author

@pedrobaeza Modified it.
Thanks

@amkarthik amkarthik mentioned this pull request Apr 3, 2023
Open
38 tasks
@amkarthik amkarthik force-pushed the 16.0-mig-mail_template_substitute branch 2 times, most recently from 35ff2ae to c4c34bf Compare April 3, 2023 10:10
@amkarthik
Copy link
Member Author

@hbrunn Can we get this merged?

@amkarthik amkarthik force-pushed the 16.0-mig-mail_template_substitute branch from c4c34bf to 93e7c8e Compare July 13, 2023 13:12
@hbrunn
Copy link
Member

hbrunn commented Jul 31, 2023

@amkarthik please remove your last commit

@amkarthik amkarthik force-pushed the 16.0-mig-mail_template_substitute branch from 93e7c8e to 527be51 Compare August 3, 2023 06:15
@amkarthik
Copy link
Member Author

@hbrunn removed it.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Aug 4, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1120-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9a64087 into OCA:16.0 Aug 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c7ed17a. Thanks a lot for contributing to OCA. ❤️

hbrunn
hbrunn reviewed Aug 5, 2024
View reviewed changes
mail_template_substitute/wizards/mail_compose_message.py
)
if substitution_template:
self.template_id = substitution_template
return super().onchange_template_id_wrapper()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amkarthik this fails as the super function has an underscore: https://github.com/OCA/OCB/blob/16.0/addons/mail/wizard/mail_compose_message.py#L176

please submit a fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed at #1432

@atchuthan atchuthan deleted the 16.0-mig-mail_template_substitute branch October 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atchuthan atchuthan atchuthan approved these changes

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amkarthik @pedrobaeza @hbrunn @OCA-git-bot @atchuthan @sbejaoui @oca-travis