Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mail_activity_creator #1133

Closed
wants to merge 14 commits into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Apr 20, 2023

Standard migration using odoo-module-migrator /ocabot migration mail_activity_creator

@bosd
Copy link
Contributor Author

bosd commented Apr 20, 2023

Oops, my script test made it into a PR.
Well. lets leave it here :)

@bosd bosd marked this pull request as ready for review April 20, 2023 15:51
@bosd bosd mentioned this pull request Apr 20, 2023
38 tasks
@simahawk
Copy link
Contributor

@bosd is it a test or what?
We another PR here #1169 would be nice to know what to do.... 😉

@bosd
Copy link
Contributor Author

bosd commented Jul 24, 2023

@simahawk
I accidentally did the migration of this module. (Was not on my todo list)
The PR states Test, because I was testing the odoo-module-migrator.

Migration succeeded with this script, so this one can be merged.

The other PR is created after this one.
On first sight not much difference on that PR. Only this has the commit messages according to oca guidelines.

@bosd bosd changed the title [16.0][MIG] mail_activity_creator TEST [16.0][MIG] mail_activity_creator Jul 24, 2023
@bosd bosd force-pushed the 16.0-mig-mail_activity_creator branch from 313b7eb to 263f106 Compare July 24, 2023 12:03
@bosd
Copy link
Contributor Author

bosd commented Jul 24, 2023

Force pushed, to re-trigger gh actions.

@ypapouin
Copy link
Contributor

ypapouin commented Sep 7, 2023

I don't understand why this module exists.

Since at least Odoo 12.0, the creator is already visible using the « i » detail button.
image

If the purpose was just adding the creator in the activity form view, why adding a new creator_uid field when create_uid already exists ?

This module should be removed from the OCA (too simple according to the rules).

Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@github-actions github-actions bot closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants