[16.0][MIG] mail_activity_done: Migration to 16.0 #1168
Conversation
have been completed. fixup moment js fixup
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_done/
|
What about this change? |
|
Hello, why was this approved now? I did test it and it does not work... |
|
@llabusch93 what is not working? |
|
I apologize for my previous response. It seems I misunderstood the functionality of the module. Upon further investigation, I discovered that the module does indeed serve the intended purpose. Although I initially expected the activity to be displayed as an object in the chatter, it appears that the module primarily allows users to access completed activities through the technical menu. Please disregard my previous remarks. The module works as intended. Thank you and apologies for any confusion caused. Cheers |
|
@amkarthik It does look like #1011 is a huge improvement over the monkeypatch. Realistically, it's not going to be merged anymore in that old release. Introducing it in a new release seems more appropriate to be honest. Please review that PR and include it here if you think it's any good. |
|
@amkarthik News about this PR? Can you include the improvement mentioned by @StefanRijnhart?
|
|
@amkarthik OK, let's continue without the improvement from #1011. I'll prepare a PR for when this is merged. Can you squash the bugfixing commits into the migration commit to make this one ready for merge? |
Changed property in test to a correct one Changed README Added necessary checks if module does not have an icon Added default value to _original_module
amkarthik
force-pushed
the
16.0-mig-mail_activity_done
branch
from
26cfc3e
to
054c690
Compare
|
@StefanRijnhart Squashed the bug fix commits. |
|
Thanks! /ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f66dbf1. Thanks a lot for contributing to OCA. ❤️ |
|
@dariodelzozzo @rven @hbrunn #1214 is ready for review. |
This is a continuation of #1059 and it contains a fix reported on the parent pull request.