Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [IMP] mail_optional_follower_notification: Add default notify followers in general settings #1424

Merged

Conversation

renda-dev
Copy link

Add a settings to set a default for the boolean 'Notifiy Followers' in the wizard

Proposing of #1184 for 14.0

If this gets merged I'll fw-port it myself to v16.0

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@Quan-nhm good for you?

Add a settings to set a default for the boolean 'Notifiy Followers' in the wizard
@renda-dev renda-dev force-pushed the 14.0-imp-mail_optional_follower_notification branch from 977af3f to bb96e92 Compare July 29, 2024 10:04
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@francesco-ooops
Copy link
Contributor

@pedrobaeza can we have a quick merge or do we need to wait for the bot tag? :)

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jul 29, 2024
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1424-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6ac69ab into OCA:14.0 Jul 29, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c16d804. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-imp-mail_optional_follower_notification branch July 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants