[IMP] mail_drop_target: add group to control mailing_trace model access #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaniszewska-dev
force-pushed
the
mail_drop_group_fix
branch
from
93f0102
to
e5ab024
Compare
ajaniszewska-dev
changed the title
ajaniszewska-dev
force-pushed
the
mail_drop_group_fix
branch
from
e5ab024
to
1af4053
Compare
| @@ -8,9 +8,13 @@ | |||
| "category": "Discuss", | |||
| "website": "https://github.com/OCA/social", | |||
| "summary": "Attach emails to Odoo by dragging them from your desktop", | |||
| "depends": ["mail"], | |||
| "depends": ["mail", "mass_mailing"], | |||
There was a problem hiding this comment.
We don't want to force those using mail_drop_target to install mass_mailing.
I the dependency is needed because what you fix is only happening when mass_mailing is installed, then you need to submit a new "glue" module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.