[MIG] mail_optional_follower_notification: Migration to 18.0 #1485

carlosdynapps · 2024-10-30T09:59:34Z

No description provided.

* [ADD] Add mail_optional_follower_notifications module * [CHG][mail_optional_follower_notifications] Readme. * [IMP][mail_optional_follower_notifications] Code review. * [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification * [IMP][mail_optional_follower_notification] Review

…e res.partner and channel

…r_notification and mail_optional_autofollow

…tify instead of notify_followers. Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)

Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/

Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/

Co-authored-by: Isabelle RICHARD <[email protected]>

…f in view

Currently translated at 50.0% (2 of 4 strings) Translation: social-14.0/social-14.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/

Currently translated at 25.0% (1 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/

Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/

Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/

Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/

NachoAlesLopez

Functionally, LGTM. The field in the composer is missing its text, but other than that it, appears to work.

Also, mind taking a look at the last two commits? They are missing the module and version in the commit message. Can you rebase and add the correct information?

NachoAlesLopez · 2024-10-31T08:47:45Z

mail_optional_follower_notification/wizard/mail_compose_message_view.xml

+                position="before"
+            >
+                <field
+                    name="notify_followers"


This field is missing it's label. Without it, the checkbox doesn't have any text in the mail composer:

[MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0

pedrobaeza

This should go to OCA/mail instead.

adrienpeiffer and others added 30 commits October 28, 2024 10:56

Upgrade version from 8 -> 9

3af43ab

mail.notification has been removed. The notify is done directly on th…

5193d06

…e res.partner and channel

Tests: Replace XML_IDs no more available in 9.0

5c6af78

Argument auto_commit in send_mail

12e67aa

Migration of mail_optional_follower_notification to 10.0

4612475

[FIX] Bad version

908ee8a

[FIX] pep8

6075f45

[IMP] Hide the checkbox for the mass mailing in mail_optional_followe…

17843d3

…r_notification and mail_optional_autofollow

[FIX] mail_optional_follower_notification: Check force_partners_to_no…

cde19ab

…tify instead of notify_followers. Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)

[FIX] README.rst syntax

2b41e22

Translated using Weblate (German)

332c80d

Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/

Translated using Weblate (Portuguese)

92fad0f

Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/

[12.0][MIG] mail_optional_follower_notification

7a90c52

[IMP] mail_optional_follower_notification: black, isort

1ac99e8

[MIG] mail_optional_follower_notification: Migration to 13.0

f4aa6a6

Update mail_optional_follower_notification/models/mail_thread.py

97a8b12

Co-authored-by: Isabelle RICHARD <[email protected]>

[IMP] pre-commit run -a

a98fb87

[13.0][FIX] mail_optional_follower_notification: change added span re…

aedc35d

…f in view

[IMP] mail_optional_follower_notification: black, isort, prettier

1d4d1e1

[MIG] mail_optional_follower_notification: Migration to 14.0

5b9c49b

[UPD] Update mail_optional_follower_notification.pot

381d7c6

[UPD] README.rst

9e658df

Translated using Weblate (Spanish)

c98584e

Currently translated at 50.0% (2 of 4 strings) Translation: social-14.0/social-14.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/

[MIG] mail_optional_follower_notificatio: Migration to 15.0

b4622c2

[UPD] Update mail_optional_follower_notification.pot

941aa0e

[UPD] README.rst

92581c0

mail_optional_follower_notification 15.0.1.0.1

9044773

[IMP] update dotfiles [ci skip]

6cad3ad

[MIG] mail_optional_follower_notification: Migration to 16.0

653eeb1

ajaniszewska-dev and others added 14 commits October 28, 2024 10:56

[FIX] fix value returned by _action_send_mail

d7f7298

mail_optional_follower_notification 16.0.1.0.1

b08595b

Translated using Weblate (Italian)

c55b599

Currently translated at 25.0% (1 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/

[UPD] README.rst

81cc613

Translated using Weblate (Spanish)

dafc137

Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/es/

[UPD] Update mail_optional_follower_notification.pot

46b6a43

Translated using Weblate (Italian)

898f985

Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/

[IMP] mail_optional_follower_notification: pre-commit execution

cefc617

[MIG] mail_optional_follower_notification: Migration to 17.0

325132d

[UPD] Update mail_optional_follower_notification.pot

2c45651

[BOT] post-merge updates

9cb10cb

NachoAlesLopez reviewed Oct 31, 2024

View reviewed changes

carlosdynapps force-pushed the 18.0-mig-mail_optional_follower_notification branch 3 times, most recently from 760f53c to e55e5c1 Compare October 31, 2024 11:25

[MIG] mail_optional_follower_notification: Migration to 18.0

23622d8

[MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0

carlosdynapps force-pushed the 18.0-mig-mail_optional_follower_notification branch from 142af37 to 23622d8 Compare October 31, 2024 12:28

NachoAlesLopez approved these changes Oct 31, 2024

View reviewed changes

carlosdynapps mentioned this pull request Nov 12, 2024

Migration to version 18.0 #1458

Open

26 tasks

pedrobaeza requested changes Nov 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] mail_optional_follower_notification: Migration to 18.0 #1485

[MIG] mail_optional_follower_notification: Migration to 18.0 #1485

carlosdynapps commented Oct 30, 2024

NachoAlesLopez left a comment

NachoAlesLopez Oct 31, 2024

pedrobaeza left a comment

[MIG] mail_optional_follower_notification: Migration to 18.0 #1485

Are you sure you want to change the base?

[MIG] mail_optional_follower_notification: Migration to 18.0 #1485

Conversation

carlosdynapps commented Oct 30, 2024

NachoAlesLopez left a comment

Choose a reason for hiding this comment

NachoAlesLopez Oct 31, 2024

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment