[16.0][IMP] sale_timesheet_line_exclude: add security group #707
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
16.0-sale_timesheet_line_exclude-security-sbi
branch
from
8b8d638
to
ced87f4
Compare
alexey-pelykh
requested changes
Aug 18, 2024
sale_timesheet_line_exclude/security/exclude_from_sale_order.xml
Outdated
Show resolved
Hide resolved
sbidoul
force-pushed
the
16.0-sale_timesheet_line_exclude-security-sbi
branch
from
ced87f4
to
696663f
Compare
|
I feel like you didn't add the file you wanted to add :) |
What do you mean? |
sbidoul
force-pushed
the
16.0-sale_timesheet_line_exclude-security-sbi
branch
from
696663f
to
34a29d3
Compare
|
Ah, the README, updated now. |
alexey-pelykh
approved these changes
Aug 18, 2024
gbrito
approved these changes
Aug 18, 2024
alexey-pelykh
changed the title
We don't copy the field by default, because it breaks the OE timesheet grid for users in the security group that hides the field. Functionally, it also makes sens to not copy this field, because it is better to consider the new line not excluded by default.
|
I discovered a bug where the security group breaks the timesheet grid, which attemps to copy timesheet lines. So I declare the field copy=False, which makes sense since we normally want the copied lines to be "not excluded" by default. |
alexey-pelykh
approved these changes
Aug 22, 2024
|
This PR has the |
gbrito
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #705
This should be merged with a minor or major version bump as it adds a security group that will need to be added to relevant users in order to preserve functionality.